Skip to content

Remove macos-13 from workflows as it will be deprecated by 2025/11/14 #18772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove macos-13 from workflows as it will be deprecated by 2025/11/14 #18772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 8 additions & 19 deletions .github/workflows/assemble.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,22 @@ jobs:
strategy:
matrix:
java: [ 21, 23 ]
os: [ubuntu-latest, windows-latest, macos-13, ubuntu-24.04-arm]
os: [ubuntu-latest, windows-latest, ubuntu-24.04-arm]
steps:
- uses: actions/checkout@v4
- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: temurin
- name: Setup docker (missing on MacOS)
id: setup_docker
if: runner.os == 'macos'
continue-on-error: true
run: |
brew install docker colima coreutils
gtimeout 15m colima start
shell: bash
- name: Run Gradle (assemble)
if: runner.os == 'macos' && steps.setup_docker.outcome != 'success'
run: |
# Report success even if previous step failed (Docker on MacOS runner is very unstable)
exit 0;
# GitHub Actions still not supporting arm64 dind yet
Copy link
Member

@andrross andrross Jul 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears we have no path forward for assemble coverage on MacOS. That raises the question of why are we removing it now when it will still work for the next 4 months?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can keep the PR open in draft mode until then.
In any way until github actions update their M2 hardware to M3 or above it is hard to get dind run on arm64 macOS.

Thanks.

# https://github.com/douglascamata/setup-docker-macos-action?tab=readme-ov-file#arm64-processors-m-series-used-on-macos-14-images-and-beyond-are-unsupported
# And they are deprecating the x64 macos-13 runner by 2025/11/14
# https://github.blog/changelog/2025-07-11-upcoming-changes-to-macos-hosted-runners-macos-latest-migration-and-xcode-support-policy-updates/
# All new macos-* are arm64 runner by default and x64 runner requires `larger` runner
# https://github.com/actions/runner-images?tab=readme-ov-file#available-images
# Only use non-arm64 agent in this workflow
- name: Run Gradle (assemble)
shell: bash
if: runner.os != 'macos'
run: |
./gradlew assemble --parallel --no-build-cache -PDISABLE_BUILD_CACHE
- name: Run Gradle (assemble)
if: runner.os == 'macos' && steps.setup_docker.outcome == 'success'
run: |
./gradlew assemble --parallel --no-build-cache -PDISABLE_BUILD_CACHE
2 changes: 1 addition & 1 deletion .github/workflows/precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
java: [ 21, 23 ]
os: [ubuntu-latest, windows-latest, macos-latest, macos-13, ubuntu-24.04-arm]
os: [ubuntu-latest, windows-latest, macos-latest, ubuntu-24.04-arm]
include:
- java: 21
os: 'windows-2025'
Expand Down
Loading