-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add false_allow_templates as a dynamic mapping option #18825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add false_allow_templates as a dynamic mapping option #18825
Conversation
❌ Gradle check result for 4f37b48: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 0a6476a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The DCO check and precommit check is failed, please check the failure message to make them pass. |
Update tests Tests Tests Cleanup Tested, cleanup Cleanup Signed-off-by: Bruce Hong <[email protected]>
0a6476a
to
82ee0eb
Compare
Signed-off-by: Bruce Hong <[email protected]>
❌ Gradle check result for 249f59c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bruce Hong <[email protected]>
❌ Gradle check result for 7a2535e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 13408ce: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Known flaky test failed, listed here
|
Signed-off-by: Bruce Hong <[email protected]>
13408ce
to
528e8ac
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18825 +/- ##
============================================
+ Coverage 72.75% 72.83% +0.07%
- Complexity 68520 68593 +73
============================================
Files 5570 5570
Lines 314998 315051 +53
Branches 45697 45706 +9
============================================
+ Hits 229185 229465 +280
+ Misses 67260 66953 -307
- Partials 18553 18633 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Bruce Hong <[email protected]>
❌ Gradle check result for d759498: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bruce Hong <[email protected]>
2f3bca2
to
99b9365
Compare
Signed-off-by: Bruce Hong <[email protected]>
❌ Gradle check result for 9a6762f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 22acae4: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
22acae4
to
12043cc
Compare
❌ Gradle check result for 12043cc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bruce Hong <[email protected]>
12043cc
to
217a993
Compare
Description
This PR adds the
dynamic: false_allow_templates
option to the schema. This creates mappings for any field that matchesproperties
ordynamic_templates
, and ignores any fields that do not (as opposed to rejecting altogether).Example from linked issue, the usage is:
url
matches an explicit property and the fieldsdate_timestamp
anddate_timezone
math the dynamic template:Related Issues
Resolves #18617
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.