enhance monitor to store only relevant fields for docs linked to findings #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbcd90
requested review from
AWSHurneyt,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
jowg-amazon,
lezzago,
rishabhmaurya and
riysaxen-amzn
as code owners
…ings Signed-off-by: Subhobrata Dey <[email protected]> fix it Signed-off-by: Subhobrata Dey <[email protected]>
engechas
reviewed
Aug 5, 2025
| val shouldCreateSingleAlertForFindings: Boolean? = false, | ||
| val owner: String? = "alerting" | ||
| val owner: String? = "alerting", | ||
| val metadataForFindings: List<String>? = listOf() |
There was a problem hiding this comment.
metadataForFindings -> contextFields? findingFields?
eirsep
reviewed
Aug 13, 2025
| */ | ||
| val executionId: String? = null | ||
| val executionId: String? = null, | ||
| val additionalFields: Map<String, Any>? = mapOf() |
There was a problem hiding this comment.
plz add version awareness to avoid serde issues
eirsep
requested changes
Aug 13, 2025
| */ | ||
| val executionId: String? = null | ||
| val executionId: String? = null, | ||
| val additionalFields: Map<String, Any>? = mapOf() |
There was a problem hiding this comment.
plz add version awareness to avoid serde issues
| }, | ||
| owner = sin.readOptionalString() | ||
| owner = sin.readOptionalString(), | ||
| metadataForFindings = sin.readOptionalStringList() |
There was a problem hiding this comment.
plz add version awareness to avoid serde issues
| val shouldCreateSingleAlertForFindings: Boolean? = false, | ||
| val owner: String? = "alerting" | ||
| val owner: String? = "alerting", | ||
| val metadataForFindings: List<String>? = listOf() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enhance monitor to store only relevant fields for docs linked to findings
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.