-
Notifications
You must be signed in to change notification settings - Fork 602
Add document for dynamic tool #10402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: zane-neo <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Fanit Kolchina <[email protected]>
|:---|:---|:---|:---| | ||
| `method` | String | Required | The HTTP method used by the API (for example, `GET`, `POST`). | | ||
| `uri` | String | Required | The API URI. Supports `${placeholder}` syntax. Placeholders are replaced at runtime with values from the agent request body. | | ||
| `request_body` | String | Optional | The API request body. Supports `{placeholder}` syntax. Placeholders are replaced at runtime with values from the agent request body. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zane-neo Should this be ${placeholder}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be Placeholders since it refers to all the ${placeholder}
mentioned before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zane-neo: Is this correct when mentioning {placeholder}
?
| request_body | String | Optional | The API request body. Supports {placeholder} syntax. Placeholders are replaced at runtime with values from the agent request body. |
Or should it be ${placeholder}
?
| request_body | String | Optional | The API request body. Supports ${placeholder} syntax. Placeholders are replaced at runtime with values from the agent request body. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @zane-neo! Doc review complete. Please answer my question, and this will be ready for editorial review.
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
1fef73f
to
b13d296
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial review
Signed-off-by: Nathan Bower <[email protected]>
Description
Documentation for dynamic tool
Issues Resolved
opensearch-project/skills#459
Version
>= 3.2
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.