-
Notifications
You must be signed in to change notification settings - Fork 627
Addressing aws lambda documentation changes #11432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Srikanth Govindarajan <[email protected]>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@dlvenable Could you review this PR please? |
kolchfa-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @srikanthjg! Please see my comments and let me know if you have any questions.
| `aws.sts_external_id` | String | Optional | External ID for STS role assumption. Must be 2-1224 characters. | ||
| `aws.sts_header_overrides` | Map | Optional | STS header overrides. Maximum of 5 headers supported. | ||
| `client.max_retries` | Integer | Optional | The maximum number of retries for failed invocations. Default is `3`. | ||
| `client.api_call_timeout` | Duration | Optional | API call timeout before timing out. Default is `60s`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "duration" be "time unit"? This is how we specify the time unit values for REST requests.
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]>
Signed-off-by: Srikanth Govindarajan <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Description
Synchronized documentation with actual code implementation,
adding missing configuration fields, correcting examples, and documenting new
features like caching, circuit breaker, and response modes that were
implemented but not documented.
Issues Resolved
Closes #[Replace this text, including the brackets, with the issue number. Leave "Closes #" so the issue is closed properly.]
Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.