Fix CreateSnapshotPolicy handling of indices array format #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CreateSnapshotPolicy component was failing when the API returned indices as an array instead of a string, causing TypeError: indices.split is not a function. Changes: - Updated getPolicy method to handle both array and string formats for indices - Added comprehensive unit tests to prevent regression - Maintains backward compatibility with existing string format Fixes issue where editing snapshot policies would fail with TypeError when indices were returned as an array from the API. Signed-off-by: Sander van de Geijn <[email protected]>
sandervandegeijn
requested review from
Hailong-am,
RamakrishnaChilaka,
SuZhou-Joe,
bowenlan-amzn,
shiv0408,
soosinha,
tandonks and
vikasvb90
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CreateSnapshotPolicy component was failing when the API returned indices as an array instead of a string, causing TypeError: indices.split is not a function. The API permits both a string and array, I was using the array. Another fix could be to make the API more restrictive but that might impact users who have done the same and actually I like the array better than a delimited string.
So, frontend fix with Claude Code to permit this. Tests succeed locally.
Changes:
Fixes issue where editing snapshot policies would fail with TypeError when indices were returned as an array from the API.
Description
Fixed the loading error
Issues Resolved
#946
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.