-
Notifications
You must be signed in to change notification settings - Fork 174
Add tutorial for agentic search #4127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for agentic search #4127
Conversation
Signed-off-by: Mingshi Liu <[email protected]>
Approved without reviewing to unblock. |
docs/tutorials/agentic_search/agentic_search_llm_generated_type.md
Outdated
Show resolved
Hide resolved
docs/tutorials/agentic_search/agentic_search_llm_generated_type.md
Outdated
Show resolved
Hide resolved
docs/tutorials/agentic_search/agentic_search_llm_generated_type.md
Outdated
Show resolved
Hide resolved
docs/tutorials/agentic_search/agentic_search_llm_generated_type.md
Outdated
Show resolved
Hide resolved
This is an experimental feature and is not recommended for use in a production environment. For updates on the progress of the feature or if you want to leave feedback, join the discussion on the [OpenSearch forum](https://forum.opensearch.org/). | ||
{: .warning} | ||
|
||
Agentic Search is a new query type proposed in OpenSearch that triggers an agent-driven workflow for query understanding, planning and execution. Instead of hand-crafting DSL, you supply a natural language question and an agent id; the agent executes a Query Planning Toolwith index/mapping introspection, and guide LLMs to produce OpenSearch DSL and run it through agentic query clause and return the search hits based on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
add space at Toolwith
In this part an agent-driven workflow for query understanding,
looks like we are suggesting we give an explanation to the query, maybe reword a little?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added space for formatting, and query understanding is terminology in search, check this https://en.wikipedia.org/wiki/Query_understanding
docs/tutorials/agentic_search/agentic_search_llm_generated_type.md
Outdated
Show resolved
Hide resolved
docs/tutorials/agentic_search/agentic_search_llm_generated_type.md
Outdated
Show resolved
Hide resolved
"request_processors": [ | ||
{ | ||
"agentic_query_translator": { | ||
"agent_id": "your_agent_id" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this processor takes a model_id and implements the tools logics inside the processor, so we can get rid of the agent steps 4 and 5? We can implement a default agent inside this processor to simplify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have default agent for now, but we will consider about it
Signed-off-by: Mingshi Liu <[email protected]>
Signed-off-by: Mingshi Liu <[email protected]>
@@ -0,0 +1,685 @@ | |||
--- | |||
layout: default | |||
title: Agentic search with a llmGenerated query type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we tune the title ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to open new PR for remaining comments, let's merge for unblocking the release blog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the title in the new PR #4128
please move the discussion to the following PR , thanks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4127 +/- ##
=========================================
Coverage 81.64% 81.65%
Complexity 8830 8830
=========================================
Files 761 761
Lines 38099 38099
Branches 4250 4250
=========================================
+ Hits 31107 31110 +3
+ Misses 5166 5163 -3
Partials 1826 1826
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Add tutorial for agentic search
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.