Add permissive mode setting #4611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykmr1224
added
enhancement
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
added
maintenance
ykmr1224
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar and
yuancu
as code owners
penghuo
reviewed
Oct 22, 2025
| final RelDataType relKey = TYPE_FACTORY.createSqlType(SqlTypeName.VARCHAR); | ||
| return TYPE_FACTORY.createMapType( | ||
| relKey, TYPE_FACTORY.createSqlType(SqlTypeName.BINARY), nullable); | ||
| relKey, TYPE_FACTORY.createSqlType(SqlTypeName.ANY), nullable); |
There was a problem hiding this comment.
| schema("lastname", "string"), | ||
| schema("department", "string"), | ||
| schema("salary", "int")); | ||
| verifyDataRows(result, rows("John", "Doe", "Engineering", 75000)); |
There was a problem hiding this comment.
Add explain validation in the tests.
| Table getTable(DataSourceSchemaName dataSourceSchemaName, String tableName); | ||
|
|
||
| /** Get {@link Table} which allows permissive mode or not. */ | ||
| default Table getPermissiveAwareTable( |
There was a problem hiding this comment.
getPermissiveAwareTable is temporay change? if yes, add TODO.
There was a problem hiding this comment.
This will be kept to avoid permissive is applied to SQL.
(Only Calcite PPL implementation will use this method to allow permissive mode)
Comment on lines
+122
to
+124
|
|
||
| try { | ||
| for (Map.Entry<String, ExprValue> entry : value.tupleValue().entrySet()) { |
There was a problem hiding this comment.
only the top level <k, v> are extracted? what if field name is field.f1.f2?
There was a problem hiding this comment.
Hmm, do we want to flatten nested data?
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_MAPfield typed asMAP<String, Object>(dynamic fields).Related Issues
Permissive mode RFC: #4349
Dynamic fields RFC: #4433
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.