[Backport 2.19-dev] Allow renaming group-by fields to existing field names #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Parent: [Backport 2.19-dev] Support relevance query functions pushdown implementation in Calcite (#3834)

opensearch-trigger-bot wants to merge 1 commit into 2.19-dev from backport/backport-4586-to-2.19-dev

+143 −1

Contributor

opensearch-trigger-bot bot commented Oct 24, 2025

Backport a86a5a7 from #4586.


          Allow renaming group-by fields to existing field names (#4586)

* Rename fields to intended ones after aggregation

Signed-off-by: Yuanchun Shen <[email protected]>

* Add a defense check

Signed-off-by: Yuanchun Shen <[email protected]>

* Remove defense check

Signed-off-by: Yuanchun Shen <[email protected]>

* Handle cases where there exist duplicated group keys

Signed-off-by: Yuanchun Shen <[email protected]>

---------

Signed-off-by: Yuanchun Shen <[email protected]>
(cherry picked from commit a86a5a7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot requested review from GumpacG, LantaoJin, MaxKsyunz, Swiddis, YANG-DB, Yury-Fridlyand, acarbonetto, anirudha, dai-chen, derek-ho, forestmvey, joshuali925, kavithacm, mengweieric, noCharger, penghuo, ps48, qianheng-aws, seankao-az and ykmr1224 as code owners

October 24, 2025 02:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ps48 Awaiting requested review from ps48 ps48 is a code owner

kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

penghuo Awaiting requested review from penghuo penghuo is a code owner

seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

anirudha Awaiting requested review from anirudha anirudha is a code owner

forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

noCharger Awaiting requested review from noCharger noCharger is a code owner

qianheng-aws Awaiting requested review from qianheng-aws qianheng-aws is a code owner

At least 2 approving reviews are required to merge this pull request.

Labels

None yet