Add TEP for scoping token to a repositories #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savitaashture
force-pushed
the
scope_token_to_repolist
branch
from
e8d91aa to
8c44558
Compare
|
cc @chmouel |
savitaashture
force-pushed
the
scope_token_to_repolist
branch
from
8c44558 to
6a25148
Compare
savitaashture
force-pushed
the
scope_token_to_repolist
branch
from
6a25148 to
dbd194e
Compare
chmouel
reviewed
Apr 20, 2023
|
|
||
| ## Motivation/UseCase | ||
|
|
||
| Their is a use case where CI Repos Differ from CD Repos, and the teams would like the generated GitHub Token from Pipelines As Code to allow control over these secondary repos, even if they were not the one triggering the pipeline. |
There was a problem hiding this comment.
I don't think it's a CI/CD use case but yeah.
chmouel
reviewed
Apr 20, 2023
|
|
||
| * The configuration exist in `pipelines-as-code` configmap. | ||
|
|
||
| * The key which used to have list of Repos is `secret-github-app-scope-extra-repos` |
There was a problem hiding this comment.
maybe add that the github app was installed for those repos.
chmouel
reviewed
Apr 20, 2023
|
|
||
| ### Scoping GH token to a list of Repos provided by Repository level configuration | ||
|
|
||
| * Scope token to a list of Repos provided by `repo_list_to_scope_token` spec configuration within the Repository custom resource |
There was a problem hiding this comment.
maybe i would called it scopped_token_repos for the option
chmouel
reviewed
Apr 20, 2023
| failed to scope token to repositories in namespace article-pipelines with error : could not refresh installation id 36523992's token: received non 2xx response status \"422 Unprocessable Entity\" when fetching https://api.github.com/app/installations/36523992/access_tokens: Post \"https://api.github.com/repos/savitaashture/article/check-runs\ | ||
| ``` | ||
|
|
||
| 5. If repos are given by `repo_list_to_scope_token` or `secret-github-app-scope-extra-repos` failed to scope token for any reason then CI will not run. |
There was a problem hiding this comment.
maybe add a note that if it's a github webhook method repo CR then ignore it completely, user would need to have the right on their PAT for the repos they have access to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.