UPSTREAM: <drop>: OKD-276: Fix InPlacePodVerticalScaling tests

[bitoku]

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

This PR fixes InPlacePodVerticalScaling tests. https://issues.redhat.com/browse/OKD-276
The upstream fix is kubernetes#132791
We may need to drop this change and make a new one because the test structure change in 1.34.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[openshift-ci-robot]

@bitoku: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• b33e207|UPSTREAM: : Fix cpu.weight wrong conversion in InPlacePodVerticalScaling tests: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[bertinatto]

Please amend the commit message to contain the number of the upstream PR.

This PR fixes InPlacePodVerticalScaling tests.

Where can we see the test failure? Is the test flaking or perma-failing?

We may need to drop this change and make a new one because the test structure change in 1.34.

This isn't clear to me. The upstream PR is targetting v1.34 (master branch), and this PR is targetting openshift/master (which is currently v1.33). Do you mean that the downstream patch is different than the upstream patch?

[bitoku]

@bertinatto
The failure is filed here https://issues.redhat.com/browse/OKD-276. (I added it in the description too) It's perma-failing.

This isn't clear to me. The upstream PR is targetting v1.34 (master branch), and this PR is targetting openshift/master (which is currently v1.33). Do you mean that the downstream patch is different than the upstream patch?

Yes, the aim is the same but the change is different. That's because the test code changed from 1.33 to 1.34.
The root cause is crun behaviour change.
The upstream still uses the old crun, so the tests won't fail in 1.33 (and even in 1.34 yet), but in OKD it has the newest crun and the tests are failing even in 1.33.

That's why we need this patch in 1.33 (ocp4.20).
Do I need to change the commit message, even if the change is different?
We will remove this patch anyway in ocp4.21 because it'll block the rebase of 1.34, but we need a new one for ocp4.21 if we can't get the upstream PR merged in 1.34.

[openshift-ci-robot]

@bitoku: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 75f37b9|UPSTREAM: : Fix cpu.weight wrong conversion in InPlacePodVerticalScaling tests: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[haircommander]

maybe call this UPSTREAM: <drop>: Fix InPlacePodVerticalScaling tests as the 1.34 fix would be a carry pulled from 1.35 update, so this 1.33/4.20 change should be dropped

[openshift-ci-robot]

@bitoku: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 8ef4d60|UPSTREAM: : Fix cpu.weight wrong conversion in InPlacePodVerticalScaling tests: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[bitoku]

/retest

[bertinatto]

/remove-label backports/unvalidated-commits
/lgtm

CC @jacobsee

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, bitoku

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bitoku]

/retest-required

[openshift-ci-robot]

@bitoku: This pull request references OKD-276 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

This PR fixes InPlacePodVerticalScaling tests. https://issues.redhat.com/browse/OKD-276
The upstream fix is kubernetes#132791
We may need to drop this change and make a new one because the test structure change in 1.34.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bitoku]

/skip

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 50d892e and 2 for PR HEAD 8ef4d60 in total

[bitoku]

/retest-required

[bitoku]

/retest-required

[bitoku]

/retest-required

[bitoku]

/retest-required

[bitoku]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 672cb75 and 1 for PR HEAD 8ef4d60 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 672cb75 and 2 for PR HEAD 8ef4d60 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 672cb75 and 2 for PR HEAD 8ef4d60 in total

[openshift-ci]

@bitoku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	75f37b9	link	false	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-techpreview-serial	8ef4d60	link	false	/test e2e-aws-ovn-techpreview-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[haircommander]

@bitoku I was wrong about the semantics of I guess this would be a so it's carried for 1.33 release, and then it would be dropped in 1.34

[bitoku]

@haircommander yeah that's what I'm trying to do.
For 1.34/4.21, I'm going to cherry pick the upstream PR.

[bitoku]

/retest-required

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.20.0-202508150152.p0.g3ce821a.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.20.0-202508150152.p0.g3ce821a.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.20.0-202508150152.p0.g3ce821a.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.20.0-202508150152.p0.g3ce821a.assembly.stream.el9.
All builds following this will include this PR.