Skip to content

Conversation

@pablintino
Copy link
Contributor

@pablintino pablintino commented Jul 8, 2025

- What I did
Set the ClusterStability for our openshift/machine-config-operator/disruptive suite to `ClusterStabilityDisruptive and set test timeout to 120 minutes

- How to verify it

  1. Build the OTE binary
  2. Call it to check if it properly reports its disruptive nature and a 7200000000000 timeout
_output/linux/amd64/machine-config-tests-ext info
{
    "apiVersion": "v1.1",
    "source": {
        "commit": "8e4b9682a339d243b8d562902fa1d39fd16bd3ed",
        "build_date": "2025-07-08T12:00:11Z",
        "git_tree_state": "clean"
    },
    "component": {
        "product": "openshift",
        "type": "payload",
        "name": "machine-config-operator"
    },
    "suites": [
        {
            "name": "openshift/machine-config-operator/disruptive",
            "description": "",
            "parents": [
                "openshift/disruptive"
            ],
            "qualifiers": [
                "(source == \"openshift:payload:machine-config-operator\") \u0026\u0026 (name.contains(\"[Suite:openshift/machine-config-operator/disruptive\"))"
            ],
            "clusterStability": "Disruptive",
            "testTimeout": 7200000000000
        }
    ],
    "images": null
}

- Description for the changelog
Set the ClusterStability for our openshift/machine-config-operator/disruptive suite to `ClusterStabilityDisruptive and set test timeout to 120 minutes

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2025

@pablintino: This pull request references MCO-1739 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did
Set the ClusterStability for our openshift/machine-config-operator/disruptive suite to ClusterStabilityDisruptive

- How to verify it

  1. Build the OTE binary
  2. Call it to check if it properly reports its disruptive nature
_output/linux/amd64/machine-config-tests-ext info
{
   "apiVersion": "v1.1",
   "source": {
       "commit": "96812fe869765e8fdf95783c2fa28c4449299f82",
       "build_date": "2025-07-08T10:07:06Z",
       "git_tree_state": "clean"
   },
   "component": {
       "product": "openshift",
       "type": "payload",
       "name": "machine-config-operator"
   },
   "suites": [
       {
           "name": "openshift/machine-config-operator/disruptive",
           "description": "",
           "parents": [
               "openshift/disruptive"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:machine-config-operator\") \u0026\u0026 (name.contains(\"[Suite:openshift/machine-config-operator/disruptive\"))"
           ],
           "clusterStability": "Disruptive"
       }
   ],
   "images": null
}

- Description for the changelog
Set the ClusterStability for our openshift/machine-config-operator/disruptive suite to ClusterStabilityDisruptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
@pablintino pablintino force-pushed the flag-ote-disruptive-suite-as-ginkgo-disruptive-for-origin branch from 96812fe to 8e4b968 Compare July 8, 2025 12:00
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2025

@pablintino: This pull request references MCO-1739 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did
Set the ClusterStability for our openshift/machine-config-operator/disruptive suite to `ClusterStabilityDisruptive and set test timeout to 120 minutes

- How to verify it

  1. Build the OTE binary
  2. Call it to check if it properly reports its disruptive nature and a 7200000000000 timeout
_output/linux/amd64/machine-config-tests-ext info
{
   "apiVersion": "v1.1",
   "source": {
       "commit": "8e4b9682a339d243b8d562902fa1d39fd16bd3ed",
       "build_date": "2025-07-08T12:00:11Z",
       "git_tree_state": "clean"
   },
   "component": {
       "product": "openshift",
       "type": "payload",
       "name": "machine-config-operator"
   },
   "suites": [
       {
           "name": "openshift/machine-config-operator/disruptive",
           "description": "",
           "parents": [
               "openshift/disruptive"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:machine-config-operator\") \u0026\u0026 (name.contains(\"[Suite:openshift/machine-config-operator/disruptive\"))"
           ],
           "clusterStability": "Disruptive",
           "testTimeout": 7200000000000
       }
   ],
   "images": null
}

- Description for the changelog
Set the ClusterStability for our openshift/machine-config-operator/disruptive suite to `ClusterStabilityDisruptive and set test timeout to 120 minutes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pablintino pablintino changed the title MCO-1739: Tell origin our suite is disruptive MCO-1739: Tell origin our suite is disruptive and set timeout Jul 8, 2025
@stbenjam
Copy link
Member

stbenjam commented Jul 8, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! One question based on the slack discussion, until openshift/origin#29888 merges, will this correctly supercede the origin definition?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino, stbenjam, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pablintino,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9990cab and 2 for PR HEAD 8e4b968 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9990cab and 2 for PR HEAD 8e4b968 in total

@pablintino
Copy link
Contributor Author

/retest-required

@yuqi-zhang
Copy link
Contributor

/override ci/prow/e2e-gcp-op

Can't affect gcp-op in this case

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op

In response to this:

/override ci/prow/e2e-gcp-op

Can't affect gcp-op in this case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 10276ff and 2 for PR HEAD 8e4b968 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview 8e4b968 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-aws-ovn-upgrade-out-of-change 8e4b968 link false /test e2e-aws-ovn-upgrade-out-of-change
ci/prow/okd-scos-e2e-aws-ovn 8e4b968 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-op-ocl 8e4b968 link false /test e2e-gcp-op-ocl
ci/prow/e2e-azure-ovn-upgrade-out-of-change 8e4b968 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pablintino
Copy link
Contributor Author

/test e2e-gcp-op

@openshift-merge-bot openshift-merge-bot bot merged commit c3d7b9b into openshift:main Jul 9, 2025
14 of 19 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202507091614.p0.gc3d7b9b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants