OCPBUGS-59968: Cert Controller should live fetch SAN IPs during cert rotation

[djoshy]

This takes inspiration from https://github.com/openshift/cluster-kube-apiserver-operator/blob/main/pkg/operator/certrotationcontroller/dynamic_serving.go. I did not want to vendor a whole package for that type, but most of the mechanism is similar to that; with a few adjustments for it to work with the MCO's cert controller. I also added a unit test for this particular case.

I also chose not to listen on the ARO resource, although I can include it if requested. Since we want to eventually move from vendoring non openshift API, I figured it wasn't worth plumbing that through.

How to verify:

Existing cert rotation mechanisms should remain unchanged. The easiest way to verify this is that installs and upgrades to this PR should be able to successfully scale up nodes. Examining the cert controller logs and the MCO cert objects should confirm this. (see #4669 for what to look for)

I'm not sure there is an easy way to test hostnames changes on a live cluster, edits to the apiServerInternalURI in infrastructure object is immediately stomped by the cluster-config-operator. If somehow we could even force an edit, it is likely to break a number of other configurations on the cluster. So I'm open to other ideas here 😄

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-59968, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This takes inspiration from https://github.com/openshift/cluster-kube-apiserver-operator/blob/main/pkg/operator/certrotationcontroller/dynamic_serving.go; I did not want to vendor a whole package for that type, but most of the mechanism is similar to that; with a few adjustments for it to work with the MCO's cert controller. I also added a unit test for this particular case.

How to verify:

• Existing cert rotation mechanisms should remain unchanged. The easiest way to verify this is that installs and upgrades to this PR should be able to successfully scale up nodes. Examining the cert controller logs and the MCO cert objects should confirm this. (see MCO-643: MCO-645: Implement a rotation mechanism for the MCS TLS cert #4669)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-59968, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

This takes inspiration from https://github.com/openshift/cluster-kube-apiserver-operator/blob/main/pkg/operator/certrotationcontroller/dynamic_serving.go; I did not want to vendor a whole package for that type, but most of the mechanism is similar to that; with a few adjustments for it to work with the MCO's cert controller. I also added a unit test for this particular case.

I also chose not to listen on the ARO resource, although I can include it if requested. Since we want to eventually move from vendoring non openshift API, I figured it wasn't worth plumbing that through.

How to verify:

Existing cert rotation mechanisms should remain unchanged. The easiest way to verify this is that installs and upgrades to this PR should be able to successfully scale up nodes. Examining the cert controller logs and the MCO cert objects should confirm this. (see #4669 for what to look for)

I'm not sure there is an easy way to test hostnames changes on a live cluster, edits to the apiServerInternalURI infra objects are immediately stomped by the cluster-config-operator. If somehow we could even force an edit, it is likely to break a number of other configurations on the cluster. So I'm open to other ideas here 😄

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

Thanks for the review, @pablintino I've incorporated the changes; let me know what you think!

[pablintino]

/lgtm
@djoshy thanks for considering my comments :)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [djoshy,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[djoshy]

/hold

holding for QE

[openshift-ci]

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-ocl	a3e78f3	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-aws-ovn	a3e78f3	link	true	/test e2e-aws-ovn
ci/prow/e2e-gcp-mco-disruptive	a3e78f3	link	false	/test e2e-gcp-mco-disruptive
ci/prow/okd-scos-e2e-aws-ovn	a3e78f3	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-mco-disruptive	a3e78f3	link	false	/test e2e-aws-mco-disruptive
ci/prow/e2e-azure-ovn-upgrade-out-of-change	a3e78f3	link	false	/test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-59968, which is invalid:

• expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/jira refresh

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-59968, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/unhold