OCPBUGS-58198: Fix MCP updated machine count for image mode disabling case #5271

isabella-janssen · 2025-09-02T19:39:42Z

Closes: OCPBUGS-58198

- What I did
This updates the layered node state IsDone function to properly handle the image mode disabling case. When image mode is disabling, the layered boolean flips to false and, in that case, we need to make sure the node does not have a desired image annotation value. It also adds two unit test cases to cover the image mode disabling scenario.

- How to verify it

Launch a 4.21 cluster with this PR included.

launch 4.21,openshift/machine-config-operator#5271 aws

Enable image mode in the worker MCP.

$ oc create -f - << EOF 
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
  name: worker
spec:
  machineConfigPool:
    name: worker
  imageBuilder:
    imageBuilderType: Job
  renderedImagePushSecret:
    name: $(oc get -n openshift-machine-config-operator sa builder -ojsonpath='{.secrets[0].name}')
  renderedImagePushSpec: "image-registry.openshift-image-registry.svc:5000/openshift-machine-config-operator/ocb-image:latest"
EOF

Once image mode has fully rolled out to the worker MCP, disable image mode by deleting the MachineOSConfig.

$ oc delete machineosconfig/worker

Watch the worker MCP machine counts to ensure they are properly

$ oc get mcp -w
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   True      False      False      3              3                   3                     0                      3h55m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   False     True       False      3              0                   0                     0                      3h55m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   False     True       False      3              1                   1                     0                      4h1m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   False     True       False      3              2                   2                     0                      4h6m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   True      False      False      3              3                   3                     0                      4h12m

- Description for the changelog
OCPBUGS-58198: Update the node done check to properly calculate the updated machine count when image mode is being disabled

openshift-ci · 2025-09-02T19:39:58Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2025-09-08T15:54:38Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-58198, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes: OCPBUGS-58198

- What I did
This updates the layered node state IsDone function to properly handle the image mode disabling case. When image mode is disabling, the layered boolean flips to false and, in that case, we need to make sure the node does not have a desired image annotation value.

- How to verify it

Launch a 4.21 cluster with this PR included.
launch 4.21,openshift/machine-config-operator#5271 aws
Enable image mode in the worker MCP.
$ oc create -f - << EOF 
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
 name: worker
spec:
 machineConfigPool:
   name: worker
 imageBuilder:
   imageBuilderType: Job
 renderedImagePushSecret:
   name: $(oc get -n openshift-machine-config-operator sa builder -ojsonpath='{.secrets[0].name}')
 renderedImagePushSpec: "image-registry.openshift-image-registry.svc:5000/openshift-machine-config-operator/ocb-image:latest"
EOF
Once image mode has fully rolled out to the worker MCP, disable image mode by deleting the MachineOSConfig.
$ oc delete machineosconfig/worker
Watch the worker MCP machine counts to ensure they are properly
$ oc get mcp -w
...
- Description for the changelog
OCPBUGS-58198: Update the node done check to properly calculate the updated machine count when image mode is being disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-08T16:20:48Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-58198, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

Closes: OCPBUGS-58198

- What I did
This updates the layered node state IsDone function to properly handle the image mode disabling case. When image mode is disabling, the layered boolean flips to false and, in that case, we need to make sure the node does not have a desired image annotation value.

- How to verify it

Launch a 4.21 cluster with this PR included.

launch 4.21,openshift/machine-config-operator#5271 aws

Enable image mode in the worker MCP.

$ oc create -f - << EOF 
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
 name: worker
spec:
 machineConfigPool:
   name: worker
 imageBuilder:
   imageBuilderType: Job
 renderedImagePushSecret:
   name: $(oc get -n openshift-machine-config-operator sa builder -ojsonpath='{.secrets[0].name}')
 renderedImagePushSpec: "image-registry.openshift-image-registry.svc:5000/openshift-machine-config-operator/ocb-image:latest"
EOF

Once image mode has fully rolled out to the worker MCP, disable image mode by deleting the MachineOSConfig.

$ oc delete machineosconfig/worker

Watch the worker MCP machine counts to ensure they are properly

$ oc get mcp -w
oc get mcp -w
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
worker   rendered-worker-57e1e076fce6b988ae1fea4c52e51217   True      False      False      3              3                   3                     0                      139m
worker   rendered-worker-57e1e076fce6b988ae1fea4c52e51217   True      False      False      3              3                   3                     0                      3h6m
master   rendered-master-acdee0e8f3cd80b27b84db2e9c304149   True      False      False      3              3                   3                     0                      3h6m
worker   rendered-worker-57e1e076fce6b988ae1fea4c52e51217   False     True       False      3              0                   0                     0                      3h6m
master   rendered-master-acdee0e8f3cd80b27b84db2e9c304149   False     True       False      3              0                   0                     0                      3h6m
worker   rendered-worker-57e1e076fce6b988ae1fea4c52e51217   False     True       False      3              0                   0                     0                      3h6m
worker   rendered-worker-57e1e076fce6b988ae1fea4c52e51217   False     True       False      3              0                   1                     0                      3h11m
worker   rendered-worker-57e1e076fce6b988ae1fea4c52e51217   False     True       False      3              1                   1                     0                      3h11m
worker   rendered-worker-57e1e076fce6b988ae1fea4c52e51217   False     True       False      3              1                   1                     0                      3h11m
master   rendered-master-acdee0e8f3cd80b27b84db2e9c304149   False     True       False      3              1                   1                     0                      3h12m
master   rendered-master-acdee0e8f3cd80b27b84db2e9c304149   False     True       False      3              1                   1                     0                      3h12m
worker   rendered-worker-57e1e076fce6b988ae1fea4c52e51217   False     True       False      3              1                   2                     0                      3h15m
worker   rendered-worker-57e1e076fce6b988ae1fea4c52e51217   False     True       False      3              2                   2                     0                      3h15m

- Description for the changelog
OCPBUGS-58198: Update the node done check to properly calculate the updated machine count when image mode is being disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2025-09-09T12:25:44Z

/retest-required

umohnani8 · 2025-09-09T15:57:05Z

/lgtm

djoshy · 2025-09-09T16:03:48Z

pkg/controller/common/layered_node_state.go

 		return l.IsNodeDone() && l.IsDesiredMachineConfigEqualToPool(mcp) && l.IsDesiredEqualToBuild(mosc, mosb)
 	}
-	return l.IsNodeDone() && l.IsDesiredMachineConfigEqualToPool(mcp)
+	return l.IsNodeDone() && l.IsDesiredMachineConfigEqualToPool(mcp) && !l.IsDesiredImageAnnotationPresentOnNode()


Hmm, I thought IsNodeDone() did take image annotations into account regardless of layering? Wonder when that broke 😓

https://github.com/openshift/machine-config-operator/blob/main/pkg/controller/common/layered_node_state.go#L185

The current state of the IsNodeDone function unfortunately does not seem to account for nodes that have not yet started updating when layering is disabled in a pool. When image mode is disabled, the first node to update removes the desired image annotation, but the remaining nodes keep the annotations as is, which leads the path trough the function to be:

if !desiredOK && !currentOK { return true } <-- we pass over this since the annotations still exist in the node

if desired == "" { return false } <-- we pass over this since the annotation is still populated

if current == "" { return false } <-- we pass over this since the annotation is still populated

return desired == current <-- desired equals current since the update hasn't started yet so the annotations have not changed yet either

I'm not quite sure when exactly this flow broke, but it seems like sometime in 4.19. 🙁

Ahh that makes sense! I must've overlooked this when I tried to re-implement LayeredNodeState after the API move. 🤔 Or we've always never considered this 😅 Would you mind adding a unit test for this scenario in status_test.go? I feel like that's a good place for it, but open to others too. There's probably a few functions there that utilize this call.

I added two cases to that test here. Please let me know how you feel that coverage is, and I can adjust as needed.

looks good to me, thanks!

…case & add unit test cases for scenario

openshift-ci-robot · 2025-09-10T00:54:23Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-58198, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes: OCPBUGS-58198

- What I did
This updates the layered node state IsDone function to properly handle the image mode disabling case. When image mode is disabling, the layered boolean flips to false and, in that case, we need to make sure the node does not have a desired image annotation value. It also adds two unit test cases to cover the image mode disabling scenario.

- How to verify it

Launch a 4.21 cluster with this PR included.
launch 4.21,openshift/machine-config-operator#5271 aws
Enable image mode in the worker MCP.
$ oc create -f - << EOF 
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
 name: worker
spec:
 machineConfigPool:
   name: worker
 imageBuilder:
   imageBuilderType: Job
 renderedImagePushSecret:
   name: $(oc get -n openshift-machine-config-operator sa builder -ojsonpath='{.secrets[0].name}')
 renderedImagePushSpec: "image-registry.openshift-image-registry.svc:5000/openshift-machine-config-operator/ocb-image:latest"
EOF
Once image mode has fully rolled out to the worker MCP, disable image mode by deleting the MachineOSConfig.
$ oc delete machineosconfig/worker
Watch the worker MCP machine counts to ensure they are properly
$ oc get mcp -w
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   True      False      False      3              3                   3                     0                      3h55m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   False     True       False      3              0                   0                     0                      3h55m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   False     True       False      3              1                   1                     0                      4h1m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   False     True       False      3              2                   2                     0                      4h6m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   True      False      False      3              3                   3                     0                      4h12m
- Description for the changelog
OCPBUGS-58198: Update the node done check to properly calculate the updated machine count when image mode is being disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

djoshy · 2025-09-10T13:54:54Z

/lgtm

openshift-ci · 2025-09-10T13:57:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [djoshy,isabella-janssen,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

isabella-janssen · 2025-09-10T14:02:22Z

/retest-required

isabella-janssen · 2025-09-11T15:21:57Z

/retest-required

ptalgulk01 · 2025-09-24T09:50:42Z

Pre-merge verified:

Verified using IPI based AWS cluster:

Applied the MOSC.

MOSC template

oc create -f - << EOF 
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
  name: worker
spec:
  machineConfigPool:
    name: worker
  imageBuilder:
    imageBuilderType: Job
  renderedImagePushSecret:
    name: $(oc get -n openshift-machine-config-operator sa builder -ojsonpath='{.secrets[0].name}')
  renderedImagePushSpec: "image-registry.openshift-image-registry.svc:5000/openshift-machine-config-operator/ocb-image:latest"
EOF
machineosconfig.machineconfiguration.openshift.io/worker created

Wait for MOSB to be succeeded

$ oc get machineosbuilds
NAME                                      PREPARED   BUILDING   SUCCEEDED   INTERRUPTED   FAILED   AGE
worker-ad7f100edb9ca029c500f1f8e3fc2920   False      False      True        False         False    7m48s

Let the MCP updated

$ oc get mcp 
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
master   rendered-master-dc47f1355ed5ab0d58b6ca86e43ff907   True      False      False      3              3                   3                     0                      118m
worker   rendered-worker-1bf198c51b8aa02365a40312b1af5cdf   True      False      False      3              3                   3                     0                      137m

Check image is applied on node

$ oc debug node/ip-10-0-74-238.us-east-2.compute.internal -- chroot /host rpm-ostree status
Starting pod/ip-10-0-74-238us-east-2computeinternal-debug-87jzg ...
To use host binaries, run `chroot /host`
State: idle
Deployments:
* ostree-unverified-registry:image-registry.openshift-image-registry.svc:5000/openshift-machine-config-operator/ocb-image@sha256:b7b33b32c73433de8381951841ebc0b42300ec7e5ad73c9d7f6ceab2abfb26a9
                   Digest: sha256:b7b33b32c73433de8381951841ebc0b42300ec7e5ad73c9d7f6ceab2abfb26a9
                  Version: 9.6.20250916-0 (2025-09-24T07:28:25Z)

Removing debug pod ...

Delete the MOSC

$ oc delete machineosconfigs worker
machineosconfig.machineconfiguration.openshift.io "worker" deleted

Check the update machinecount is happening as expected

$ oc get mcp -w
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
...
worker   rendered-worker-1bf198c51b8aa02365a40312b1af5cdf   False     True       False      3              1                   1                     0                      164m
worker   rendered-worker-1bf198c51b8aa02365a40312b1af5cdf   False     True       False      3              2                   2                     0                      169m
worker   rendered-worker-1bf198c51b8aa02365a40312b1af5cdf   True      False      False      3              3                   3                     0                      174m

$ oc debug node/ip-10-0-74-238.us-east-2.compute.internal -- chroot /host rpm-ostree status
Starting pod/ip-10-0-74-238us-east-2computeinternal-debug-nmfmq ...
To use host binaries, run `chroot /host`
State: idle
Deployments:
* ostree-unverified-registry:registry.build10.ci.openshift.org/ci-ln-iss7fwt/stable@sha256:affe070623319f860b200d2e757de096e0847bf9778b1fc1d1d24263be3ff346
                   Digest: sha256:affe070623319f860b200d2e757de096e0847bf9778b1fc1d1d24263be3ff346
                  Version: 9.6.20250916-0 (2025-09-18T04:03:33Z)

Removing debug pod ...

/label qe-approved

ptalgulk01 · 2025-09-24T09:50:57Z

/verified by @ptalgulk01

openshift-ci-robot · 2025-09-24T09:51:09Z

@ptalgulk01: This PR has been marked as verified by @ptalgulk01.

In response to this:

/verified by @ptalgulk01

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-24T13:09:49Z

/retest-required

Remaining retests: 0 against base HEAD 7d591ce and 2 for PR HEAD 7c64bec in total

openshift-ci · 2025-09-24T15:11:47Z

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-mco-disruptive	`7c64bec`	link	false	`/test e2e-gcp-mco-disruptive`
ci/prow/e2e-gcp-op-ocl	`7c64bec`	link	false	`/test e2e-gcp-op-ocl`
ci/prow/e2e-azure-ovn-upgrade-out-of-change	`7c64bec`	link	false	`/test e2e-azure-ovn-upgrade-out-of-change`
ci/prow/e2e-aws-mco-disruptive	`7c64bec`	link	false	`/test e2e-aws-mco-disruptive`
ci/prow/bootstrap-unit	`7c64bec`	link	false	`/test bootstrap-unit`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

yuqi-zhang · 2025-09-24T16:54:50Z

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade

Known CI issues

openshift-ci · 2025-09-24T17:17:02Z

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade

Known CI issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-09-24T17:21:17Z

@isabella-janssen: Jira Issue Verification Checks: Jira Issue OCPBUGS-58198
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-58198 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Closes: OCPBUGS-58198

- What I did
This updates the layered node state IsDone function to properly handle the image mode disabling case. When image mode is disabling, the layered boolean flips to false and, in that case, we need to make sure the node does not have a desired image annotation value. It also adds two unit test cases to cover the image mode disabling scenario.

- How to verify it

Launch a 4.21 cluster with this PR included.
launch 4.21,openshift/machine-config-operator#5271 aws
Enable image mode in the worker MCP.
$ oc create -f - << EOF 
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
 name: worker
spec:
 machineConfigPool:
   name: worker
 imageBuilder:
   imageBuilderType: Job
 renderedImagePushSecret:
   name: $(oc get -n openshift-machine-config-operator sa builder -ojsonpath='{.secrets[0].name}')
 renderedImagePushSpec: "image-registry.openshift-image-registry.svc:5000/openshift-machine-config-operator/ocb-image:latest"
EOF
Once image mode has fully rolled out to the worker MCP, disable image mode by deleting the MachineOSConfig.
$ oc delete machineosconfig/worker
Watch the worker MCP machine counts to ensure they are properly
$ oc get mcp -w
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   True      False      False      3              3                   3                     0                      3h55m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   False     True       False      3              0                   0                     0                      3h55m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   False     True       False      3              1                   1                     0                      4h1m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   False     True       False      3              2                   2                     0                      4h6m
worker   rendered-worker-2e189c0d0e49e7c6f573a58781bab8cd   True      False      False      3              3                   3                     0                      4h12m
- Description for the changelog
OCPBUGS-58198: Update the node done check to properly calculate the updated machine count when image mode is being disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2025-09-24T17:25:24Z

/cherrypick release-4.20

openshift-cherrypick-robot · 2025-09-24T17:26:17Z

@isabella-janssen: new pull request created: #5307

In response to this:

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025

isabella-janssen force-pushed the ocpbugs-58198 branch 4 times, most recently from a62ba6f to 7cc52a4 Compare September 8, 2025 11:37

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 8, 2025

isabella-janssen force-pushed the ocpbugs-58198 branch 4 times, most recently from 61b5b1b to 7709548 Compare September 8, 2025 15:49

isabella-janssen changed the title ~~(WIP)~~ (WIP) OCPBUGS-58198: Fix MCP updated machine count for image mode disabling case Sep 8, 2025

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 8, 2025

isabella-janssen marked this pull request as ready for review September 8, 2025 15:54

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 8, 2025

openshift-ci bot requested review from sergiordlr, dkhater-redhat and umohnani8 September 8, 2025 15:54

isabella-janssen changed the title ~~(WIP) OCPBUGS-58198: Fix MCP updated machine count for image mode disabling case~~ OCPBUGS-58198: Fix MCP updated machine count for image mode disabling case Sep 8, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2025

openshift-ci bot assigned umohnani8 Sep 9, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025

djoshy reviewed Sep 9, 2025

View reviewed changes

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025

isabella-janssen force-pushed the ocpbugs-58198 branch from e394fb0 to 619ae36 Compare September 10, 2025 00:52

controller: update is node done check to handle image mode disabling …

7c64bec

…case & add unit test cases for scenario

isabella-janssen force-pushed the ocpbugs-58198 branch from 619ae36 to 7c64bec Compare September 10, 2025 00:53

openshift-ci bot assigned djoshy Sep 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 24, 2025

openshift-merge-bot bot merged commit 905b7e5 into openshift:main Sep 24, 2025
17 of 22 checks passed

isabella-janssen deleted the ocpbugs-58198 branch September 24, 2025 17:25

openshift-cherrypick-robot mentioned this pull request Sep 24, 2025

[release-4.20] OCPBUGS-62174: Fix MCP updated machine count for image mode disabling case #5307

Open

OCPBUGS-58198: Fix MCP updated machine count for image mode disabling case #5271

OCPBUGS-58198: Fix MCP updated machine count for image mode disabling case #5271

Conversation

isabella-janssen commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Sep 2, 2025

Uh oh!

openshift-ci-robot commented Sep 8, 2025

Uh oh!

openshift-ci-robot commented Sep 8, 2025

Uh oh!

isabella-janssen commented Sep 9, 2025

Uh oh!

umohnani8 commented Sep 9, 2025

Uh oh!

djoshy Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

djoshy Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

isabella-janssen Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

djoshy Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

isabella-janssen Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

djoshy Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 10, 2025

Uh oh!

djoshy commented Sep 10, 2025

Uh oh!

openshift-ci bot commented Sep 10, 2025

Uh oh!

isabella-janssen commented Sep 10, 2025

Uh oh!

isabella-janssen commented Sep 11, 2025

Uh oh!

ptalgulk01 commented Sep 24, 2025

Uh oh!

ptalgulk01 commented Sep 24, 2025

Uh oh!

openshift-ci-robot commented Sep 24, 2025

Uh oh!

openshift-ci-robot commented Sep 24, 2025

Uh oh!

openshift-ci bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuqi-zhang commented Sep 24, 2025

Uh oh!

openshift-ci bot commented Sep 24, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 24, 2025

Uh oh!

isabella-janssen commented Sep 24, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 24, 2025

Uh oh!

Uh oh!

isabella-janssen commented Sep 2, 2025 •

edited

Loading

djoshy Sep 9, 2025 •

edited

Loading

isabella-janssen Sep 9, 2025 •

edited

Loading

openshift-ci bot commented Sep 24, 2025 •

edited

Loading