Skip to content

[release-4.19] OCPBUGS-62746: Fix MCP updated machine count for image mode disabling case #5336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.19
Choose a base branch
from
Open

[release-4.19] OCPBUGS-62746: Fix MCP updated machine count for image mode disabling case #5336

wants to merge 1 commit into from
+28 −4

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5307

/assign isabella-janssen

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 6, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-62174 has been cloned as Jira Issue OCPBUGS-62746. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-62746: Fix MCP updated machine count for image mode disabling case

In response to this:

This is an automated cherry-pick of #5307

/assign isabella-janssen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-62174: Fix MCP updated machine count for image mode disabling case [release-4.19] OCPBUGS-62746: Fix MCP updated machine count for image mode disabling case Oct 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 6, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-62746, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-62174 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-62174 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #5307

/assign isabella-janssen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member

/retest-required

yuqi-zhang
yuqi-zhang approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

Should be a safe backport

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 6, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@sergiordlr
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 7, 2025
@sergiordlr
Copy link
Contributor

sergiordlr commented Oct 7, 2025 •
edited
Loading

Pre-merge verified using IPI on AWS

AI assisted verification

● Successfully completed! The worker pool has been configured with OCL using external registry, fully updated, then OCL was disabled, and the pool was monitored during the disabling process.

  Summary of monitored status during OCL disabling:

  The worker pool (3 nodes total) correctly reported:
  - Initial state (updating): machineCount=3, readyMachineCount=0, updatedMachineCount=0
  - First node updated: machineCount=3, readyMachineCount=1, updatedMachineCount=1
  - Second node updated: machineCount=3, readyMachineCount=2, updatedMachineCount=2
  - Final state (updated): machineCount=3, readyMachineCount=3, updatedMachineCount=3

  The MCP maintained accurate readyMachineCount throughout, incrementing from 0→1→2→3 as each node completed its update. Final status shows all 3 machines ready and updated with no degraded nodes.

Double checked manually

$ oc get mcp worker -w
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
worker   rendered-worker-9a78059178e841ffebc2f2cbd3e2f698   True      False      False      3              3                   3                     0                      73m
worker   rendered-worker-9a78059178e841ffebc2f2cbd3e2f698   False     True       False      3              0                   0                     0                      73m
worker   rendered-worker-9a78059178e841ffebc2f2cbd3e2f698   False     True       False      3              0                   0                     0                      73m
worker   rendered-worker-9a78059178e841ffebc2f2cbd3e2f698   False     True       False      3              1                   1                     0                      78m
worker   rendered-worker-9a78059178e841ffebc2f2cbd3e2f698   False     True       False      3              2                   2                     0                      83m
worker   rendered-worker-9a78059178e841ffebc2f2cbd3e2f698   False     True       False      3              2                   2                     0                      83m
worker   rendered-worker-9a78059178e841ffebc2f2cbd3e2f698   True      False      False      3              3                   3                     0                      89m

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 7, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-62746, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-62174 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-62174 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

This is an automated cherry-pick of #5307

/assign isabella-janssen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member

/verified by @sergiordlr

See this comment for pre-merge verification: #5336 (comment)

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 7, 2025
@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: This PR has been marked as verified by @sergiordlr.

In response to this:

/verified by @sergiordlr

See this comment for pre-merge verification: #5336 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 85d1154 and 2 for PR HEAD 9a7c837 in total

@isabella-janssen
Copy link
Member

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3e08c8d and 1 for PR HEAD 9a7c837 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 673c0bd and 0 for PR HEAD 9a7c837 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 9a7c837 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-mco-disruptive 9a7c837 link false /test e2e-aws-mco-disruptive
ci/prow/e2e-gcp-mco-disruptive 9a7c837 link false /test e2e-gcp-mco-disruptive
ci/prow/e2e-hypershift 9a7c837 link unknown /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@isabella-janssen
Copy link
Member

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

@djoshy djoshy Awaiting requested review from djoshy

@isabella-janssen isabella-janssen Awaiting requested review from isabella-janssen

Assignees

@rbbratta rbbratta

@eurijon eurijon

@lyman9966 lyman9966

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@imatza-rh imatza-rh

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

@isabella-janssen isabella-janssen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.