Skip to content

CNV-66175: Removed virtctl prereq and command from NIC hot plug doc #97079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

sjhala-ccs
Copy link
Contributor

@sjhala-ccs sjhala-ccs commented Aug 4, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 4, 2025

@sjhala-ccs: This pull request references CNV-66175 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: CNV-66175

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Aug 4, 2025

@sjhala-ccs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sjhala-ccs sjhala-ccs requested a review from orelmisan August 4, 2025 15:35
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 4, 2025

@sjhala-ccs: This pull request references CNV-66175 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: CNV-66175

Link to docs preview: https://97079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-hot-plugging-network-interfaces.html#virt-hot-plugging-bridge-network-interface_virt-hot-plugging-network-interfaces

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sjhala-ccs!

@sjhala-ccs sjhala-ccs requested a review from yossisegev August 4, 2025 18:08
Copy link

@yossisegev yossisegev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos @orelmisan for catching this!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 5, 2025

@sjhala-ccs: This pull request references CNV-66175 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: CNV-66175

Link to docs preview: https://97079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-hot-plugging-network-interfaces.html#virt-hot-plugging-bridge-network-interface_virt-hot-plugging-network-interfaces

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ousleyp
Copy link
Member

ousleyp commented Aug 5, 2025

LGTM

@sjhala-ccs sjhala-ccs merged commit ff0490a into openshift:main Aug 5, 2025
2 checks passed
@sjhala-ccs
Copy link
Contributor Author

/cherrypick enterprise-4.20

@sjhala-ccs
Copy link
Contributor Author

/cherrypick enterprise-4.19

@sjhala-ccs
Copy link
Contributor Author

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@sjhala-ccs: #97079 failed to apply on top of branch "enterprise-4.19":

Applying: CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure
Using index info to reconstruct a base tree...
M	modules/virt-hot-plugging-bridge-network-interface-cli.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-hot-plugging-bridge-network-interface-cli.adoc
CONFLICT (content): Merge conflict in modules/virt-hot-plugging-bridge-network-interface-cli.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sjhala-ccs: new pull request created: #97144

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sjhala-ccs: #97079 failed to apply on top of branch "enterprise-4.18":

Applying: CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure
Using index info to reconstruct a base tree...
M	modules/virt-hot-plugging-bridge-network-interface-cli.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-hot-plugging-bridge-network-interface-cli.adoc
CONFLICT (content): Merge conflict in modules/virt-hot-plugging-bridge-network-interface-cli.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sjhala-ccs
Copy link
Contributor Author

/cherrypick enterprise-4.17

@sjhala-ccs
Copy link
Contributor Author

/cherrypick enterprise-4.16

@sjhala-ccs
Copy link
Contributor Author

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@sjhala-ccs: #97079 failed to apply on top of branch "enterprise-4.17":

Applying: CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure
Using index info to reconstruct a base tree...
M	modules/virt-hot-plugging-bridge-network-interface-cli.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-hot-plugging-bridge-network-interface-cli.adoc
CONFLICT (content): Merge conflict in modules/virt-hot-plugging-bridge-network-interface-cli.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sjhala-ccs: #97079 failed to apply on top of branch "enterprise-4.16":

Applying: CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure
Using index info to reconstruct a base tree...
M	modules/virt-hot-plugging-bridge-network-interface-cli.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-hot-plugging-bridge-network-interface-cli.adoc
CONFLICT (content): Merge conflict in modules/virt-hot-plugging-bridge-network-interface-cli.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sjhala-ccs: #97079 failed to apply on top of branch "enterprise-4.15":

Applying: CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure
Using index info to reconstruct a base tree...
M	modules/virt-hot-plugging-bridge-network-interface-cli.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-hot-plugging-bridge-network-interface-cli.adoc
CONFLICT (content): Merge conflict in modules/virt-hot-plugging-bridge-network-interface-cli.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-66175: Removed virtctl prereq and command from NIC hot plug procedure

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants