Skip to content

OPRUN-4250: Upgrade indirects and remove pinned because of incompatibility with k8s.io/apiserver #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OPRUN-4250: Upgrade indirects and remove pinned because of incompatibility with k8s.io/apiserver #1149

wants to merge 1 commit into from

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Nov 11, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4250 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86
camilamacedo86 commented Nov 11, 2025
View reviewed changes
camilamacedo86
camilamacedo86 commented Nov 11, 2025
View reviewed changes
camilamacedo86
camilamacedo86 commented Nov 11, 2025
View reviewed changes
camilamacedo86
camilamacedo86 commented Nov 11, 2025
View reviewed changes
camilamacedo86
camilamacedo86 commented Nov 11, 2025
View reviewed changes
camilamacedo86
camilamacedo86 commented Nov 11, 2025
View reviewed changes
go.mod

replace (
// pinned because of incompatibility with k8s.io/apiserver
github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20200326155132-2a6cd50aedd0 // release-4.5
Copy link
Contributor Author

@camilamacedo86 camilamacedo86 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed for we use the latest version
And update the indirect to match with upstream

camilamacedo86
camilamacedo86 commented Nov 11, 2025
View reviewed changes
camilamacedo86
camilamacedo86 commented Nov 11, 2025
View reviewed changes
@camilamacedo86 camilamacedo86 changed the title OPRUN-4250: Upgrade versions; ocp, kube-api, opm and indirects (WIP requires we get sync https://github.com/operator-framework/operator-lifecycle-manager/pull/3707) OPRUN-4250: Upgrade versions; ocp, kube-api, opm and indirects Nov 11, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2025
@camilamacedo86 camilamacedo86 changed the title (WIP requires we get sync https://github.com/operator-framework/operator-lifecycle-manager/pull/3707) OPRUN-4250: Upgrade versions; ocp, kube-api, opm and indirects OPRUN-4250: Upgrade versions; ocp, kube-api, opm and indirects Nov 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2025
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Nov 13, 2025

/retest-required

anik120
anik120 reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@tmshort
Copy link
Contributor

tmshort commented Nov 13, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2025
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Nov 16, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2025

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

anik120
anik120 approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2025
@jianzhangbjz
Copy link
Member

jianzhangbjz commented Nov 20, 2025

/payload-job periodic-ci-openshift-operator-framework-olm-release-4.21-periodics-e2e-aws-ovn-extended-f1

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

@jianzhangbjz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-operator-framework-olm-release-4.21-periodics-e2e-aws-ovn-extended-f1

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/acf68210-c5ee-11f0-8565-04f922d2bb3e-0

@camilamacedo86 camilamacedo86 changed the title OPRUN-4250: Upgrade versions; ocp, kube-api, opm and indirects OPRUN-4250: Upgrade indirects and remove pinned because of incompatibility with k8s.io/apiserver Nov 20, 2025
anik120
anik120 reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford Awaiting requested review from joelanford

@oceanc80 oceanc80 Awaiting requested review from oceanc80

1 more reviewer

@anik120 anik120 anik120 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anik120 anik120

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@camilamacedo86 @openshift-ci-robot @tmshort @jianzhangbjz @anik120 @openshift-merge-robot