Merge pull request #29828 from JoelSpeed/unknown-gates-should-run-tests

openshift-merge-bot[bot] · web-flow · commit dd7a2a852e0a · 2025-06-24T09:13:50.000Z
NO-JIRA: We should always run tests where we have no opinion on their gate
diff --git a/pkg/clioptions/suiteselection/feature_filter.go b/pkg/clioptions/suiteselection/feature_filter.go
@@ -70,7 +70,11 @@ func (f *featureGateFilter) includeTest(name string) bool {
 		return false
 	}
 
-	return f.enabled.HasAll(featureGates...)
+	// It is important that we always return true if we don't know the status of the gate.
+	// This generally means we have no opinion on whether the feature is on or off.
+	// We expect the default case to be on, as this is what would happen after a feature is promoted,
+	// and the gate is removed.
+	return true
 }
 
 func includeNonFeatureGateTest(name string) bool {

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,11 @@ func (f *featureGateFilter) includeTest(name string) bool {`
`70`	`70`	`return false`
`71`	`71`	`}`
`72`	`72`
`73`		`- return f.enabled.HasAll(featureGates...)`
	`73`	`+ // It is important that we always return true if we don't know the status of the gate.`
	`74`	`+ // This generally means we have no opinion on whether the feature is on or off.`
	`75`	`+ // We expect the default case to be on, as this is what would happen after a feature is promoted,`
	`76`	`+ // and the gate is removed.`
	`77`	`+ return true`
`74`	`78`	`}`
`75`	`79`
`76`	`80`	`func includeNonFeatureGateTest(name string) bool {`