CORENET-5668: Update IPsec e2e test to validate NAT-T encapsulation option #29563
Conversation
openshift-merge-robot
added
the
needs-rebase
|
/lgtm I assume you need another PR in release for the lanes? |
openshift-merge-robot
removed
the
needs-rebase
|
which job here executes the ipsec code? I want to have a look at the logs. |
|
/hold Want to see the e2e logs. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-aws-ovn-ipsec-serial |
yes @martinkennelly , we need another CI lane to test nat-t changes. you can currently look at e2e-aws-ovn-ipsec-serial lane (https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-origin-main-e2e-aws-ovn-ipsec-serial) for ipsec test results. |
pperiyasamy
changed the title
|
@pperiyasamy: This pull request references CORENET-5668 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
why do you need another lane just for nat-t? cant you include it in the existing ipsec lane? |
|
/test e2e-aws-ovn-ipsec-serial infra failure @pperiyasamy above you said this test needed a new lane but i see you also testing ipsec serial ? where can i see this test your adding? |
when we try to enable nat-t in the existing ipsec lane, then there will another rollout of ovnkube-node deployment which introduce network disturbance for EW traffic during rollout, monitor events would show up again. |
@martinkennelly The failure in the run is being fixed with the bug https://issues.redhat.com/browse/OCPBUGS-54295 and we discussed about it with nmstate team (https://redhat-internal.slack.com/archives/CP7329Z5Z/p1744011607371099). |
openshift-merge-robot
added
the
needs-rebase
|
Job Failure Risk Analysis for sha: e03cab7
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: e03cab7
New tests seen in this PR at sha: e03cab7
|
pperiyasamy
force-pushed
the
nat-t-e2e
branch
2 times, most recently
from
b2b8fe2 to
db7ea4a
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/test e2e-aws-ovn-ipsec-serial |
1 similar comment
|
/test e2e-aws-ovn-ipsec-serial |
|
/retest-required |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, martinkennelly, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
1 similar comment
|
/hold Revision 6c4a40a was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
@pperiyasamy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 2969e75
into
openshift:main
|
/cherry-pick release-4.19 |
|
@pperiyasamy: new pull request created: #29944 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
This PR updates IPsec E2E to test NAT-T implemented with PR: openshift/cluster-network-operator#2573.
Note: This requires a new CI lane to test IPsec NAT-T "Always" encapsulation option.
This PR also adds an e2e tests to ensure ovnk managed pod traffic (EW traffic) is always working across nodes when
ovn-ipsec-hostdaemonset goes for multiple reboots./assign @martinkennelly