Skip to content

[release-4.16] OCPBUGS-57311: Replace RunHostCmd with Exec function to censor bearer token being exposed #29908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

[release-4.16] OCPBUGS-57311: Replace RunHostCmd with Exec function to censor bearer token being exposed #29908

merged 1 commit into from
Aug 1, 2025
+33 −30

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #29539

/assign KeerthanaAP

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 11, 2025
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-50664 has been cloned as Jira Issue OCPBUGS-57311. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-57311: Replace RunHostCmd with Exec function to censor bearer token being exposed

In response to this:

This is an automated cherry-pick of #29539

/assign KeerthanaAP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPBUGS-50664: Replace RunHostCmd with Exec function to censor bearer token being exposed [release-4.16] OCPBUGS-57311: Replace RunHostCmd with Exec function to censor bearer token being exposed Jun 11, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-57311, which is invalid:

  • expected dependent Jira Issue OCPBUGS-50664 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #29539

/assign KeerthanaAP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 11, 2025
@openshift-ci openshift-ci bot requested review from jan--f and miheer June 11, 2025 06:15
@KeerthanaAP
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 11, 2025
@openshift-ci-robot
Copy link

@KeerthanaAP: This pull request references Jira Issue OCPBUGS-57311, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-50664 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-50664 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@KeerthanaAP
Copy link

/retest

4 similar comments
@KeerthanaAP
Copy link

/retest

@KeerthanaAP
Copy link

/retest

@KeerthanaAP
Copy link

/retest

@KeerthanaAP
Copy link

/retest

tvardema
tvardema reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

@tvardema tvardema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good other than that massive spacing for the prometheus file. I assume that was not intentional.

test/extended/prometheus/prometheus.go
@@ -416,8 +415,7 @@ var _ = g.Describe("[sig-instrumentation] Prometheus [apigroup:image.openshift.i
defer g.GinkgoRecover()
ctx := context.TODO()
var (
oc = exutil.NewCLIWithPodSecurityLevel("prometheus", admissionapi.LevelBaseline)

oc = exutil.NewCLIWithPodSecurityLevel("prometheus", admissionapi.LevelBaseline)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional spacing??

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvardema We haven’t made any specific changes in this backport. It looks like the space was already present in all the previous backports.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as resolved since this is not part of the changes introduced in this backport

@tvardema
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@dgoodwin
Copy link
Contributor

/label cherry-pick-approved
/label backport-risk-assessed

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jul 28, 2025
@dgoodwin
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, openshift-cherrypick-robot, tvardema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@KeerthanaAP
Copy link

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 334a53b into openshift:release-4.16 Aug 1, 2025
25 of 47 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-57311: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-57311 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #29539

/assign KeerthanaAP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202508010636.p0.g334a53b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeerthanaAP KeerthanaAP KeerthanaAP left review comments

@tvardema tvardema tvardema left review comments

@jan--f jan--f Awaiting requested review from jan--f

@miheer miheer Awaiting requested review from miheer

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@kasturinarra kasturinarra

@KeerthanaAP KeerthanaAP

@tvardema tvardema

@jadhaj jadhaj

@lyman9966 lyman9966

@pamoedom pamoedom

@gangwgr gangwgr

@prabhapa prabhapa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.