Skip to content

OCPBUGS-57524: Fix Should properly report MCN conditions on node degrade test #29923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

OCPBUGS-57524: Fix Should properly report MCN conditions on node degrade test #29923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cdd944
debug logs
isabella-janssen Jun 17, 2025
e7677be
add in debug logs for test suite debugging
isabella-janssen Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions test/extended/machine_config/machine_config_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,21 @@ func ValidateMCNConditionOnNodeDegrade(oc *exutil.CLI, fixture string, isSno boo
degradedNodeMCN, degradedErr = clientSet.MachineconfigurationV1().MachineConfigNodes().Get(context.TODO(), degradedNode.Name, metav1.GetOptions{})
o.Expect(degradedErr).NotTo(o.HaveOccurred(), fmt.Sprintf("Error getting MCN of degraded node '%v'.", degradedNode.Name))
framework.Logf("Validating that `AppliedFilesAndOS` and `UpdateExecuted` conditions in '%v' MCN have a status of 'Unknown'.", degradedNodeMCN.Name)
o.Expect(CheckMCNConditionStatus(degradedNodeMCN, mcfgv1.MachineConfigNodeUpdateFilesAndOS, metav1.ConditionUnknown)).Should(o.BeTrue(), "Condition 'AppliedFilesAndOS' does not have the expected status of 'Unknown'.")
o.Expect(CheckMCNConditionStatus(degradedNodeMCN, mcfgv1.MachineConfigNodeUpdateExecuted, metav1.ConditionUnknown)).Should(o.BeTrue(), "Condition 'UpdateExecuted' does not have the expected status of 'Unknown'.")
// TODO: Update post debugging
degradedNodeMCNAppliedFilesCondition := GetMCNCondition(degradedNodeMCN, mcfgv1.MachineConfigNodeUpdateFilesAndOS)
degradedNodeMCNExecutedCondition := GetMCNCondition(degradedNodeMCN, mcfgv1.MachineConfigNodeUpdateExecuted)
framework.Logf("degradedNodeMCNAppliedFilesCondition.Message: %v, degradedNodeMCNAppliedFilesCondition.Reason: %v, degradedNodeMCNAppliedFilesCondition.Status: %v", degradedNodeMCNAppliedFilesCondition.Message, degradedNodeMCNAppliedFilesCondition.Reason, degradedNodeMCNAppliedFilesCondition.Status)
if !CheckMCNConditionStatus(degradedNodeMCN, mcfgv1.MachineConfigNodeUpdateFilesAndOS, metav1.ConditionUnknown) {
framework.Logf("would error on this condition for MachineConfigNodeUpdateFilesAndOS check")
framework.Logf("MCN: %v", degradedNodeMCN)
}
framework.Logf("degradedNodeMCNExecutedCondition.Message: %v, degradedNodeMCNExecutedCondition.Reason: %v, degradedNodeMCNExecutedCondition.Status: %v", degradedNodeMCNExecutedCondition.Message, degradedNodeMCNExecutedCondition.Reason, degradedNodeMCNExecutedCondition.Status)
if !CheckMCNConditionStatus(degradedNodeMCN, mcfgv1.MachineConfigNodeUpdateExecuted, metav1.ConditionUnknown) {
framework.Logf("would error on this condition for MachineConfigNodeUpdateExecuted check")
framework.Logf("MCN: %v", degradedNodeMCN)
}
// o.Expect(CheckMCNConditionStatus(degradedNodeMCN, mcfgv1.MachineConfigNodeUpdateFilesAndOS, metav1.ConditionUnknown)).Should(o.BeTrue(), "Condition 'AppliedFilesAndOS' does not have the expected status of 'Unknown'.")
// o.Expect(CheckMCNConditionStatus(degradedNodeMCN, mcfgv1.MachineConfigNodeUpdateExecuted, metav1.ConditionUnknown)).Should(o.BeTrue(), "Condition 'UpdateExecuted' does not have the expected status of 'Unknown'.")
nodeDegradedCondition := GetMCNCondition(degradedNodeMCN, mcfgv1.MachineConfigNodeNodeDegraded)
o.Expect(nodeDegradedCondition).NotTo(o.BeNil())
o.Expect(nodeDegradedCondition.Status).Should(o.Equal(metav1.ConditionTrue), "Condition 'NodeDegraded' does not have the expected status of 'True'.")
Expand Down