Skip to content

NO-JIRA: Get enabled featuregates from metrics endpoint #29952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

NO-JIRA: Get enabled featuregates from metrics endpoint #29952

merged 1 commit into from
Aug 5, 2025

Conversation

@dfajmon
Copy link
Contributor

@dfajmon dfajmon commented Jul 2, 2025 •
edited
Loading

FeatureGates are different for OpenShift and upstream. This PR changes it so we have also FeatureGates from upstream enabled using endpoint /metrics from Prometheus.

This is a continuation of openshift/kubernetes#2317

@dfajmon dfajmon changed the title UPSTREAM: <carry>: Get enabled featuregates from metrics endpoint Get enabled featuregates from metrics endpoint Jul 2, 2025
@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning July 2, 2025 14:48
jsafrane
jsafrane reviewed Jul 2, 2025
View reviewed changes
jsafrane
jsafrane reviewed Jul 2, 2025
View reviewed changes
@openshift-trt
Copy link

openshift-trt bot commented Jul 3, 2025

Job Failure Risk Analysis for sha: d32c5b3

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade Medium
Job run should complete before timeout
This test has passed 96.55% of 4292 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-disruptive High
[sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times
This test has passed 99.98% of 5416 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-hypershift-conformance IncompleteTests
Tests for this run (19) are below the historical average (1454): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@dfajmon
Copy link
Contributor Author

dfajmon commented Jul 4, 2025

/retest

1 similar comment
@dfajmon
Copy link
Contributor Author

dfajmon commented Jul 8, 2025

/retest

@openshift-trt
Copy link

openshift-trt bot commented Jul 8, 2025

Job Failure Risk Analysis for sha: 432890f

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive High
[sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times
This test has passed 99.98% of 5242 runs on release 4.20 [Overall] in the last week.
---
[sig-arch] events should not repeat pathologically for ns/openshift-etcd
This test has passed 100.00% of 15 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:hidden Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:micro-downgrade] in the last week.
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 69.74% of 5416 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-metal-ipi-virtualmedia IncompleteTests
Tests for this run (22) are below the historical average (1560): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2025
@openshift-trt
Copy link

openshift-trt bot commented Jul 29, 2025

Job Failure Risk Analysis for sha: e702f41

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-virtualmedia IncompleteTests
Tests for this run (104) are below the historical average (2603): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

jsafrane
jsafrane reviewed Jul 31, 2025
View reviewed changes
jsafrane
jsafrane reviewed Jul 31, 2025
View reviewed changes
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2025
@dfajmon dfajmon changed the title Get enabled featuregates from metrics endpoint NO-JIRA: Get enabled featuregates from metrics endpoint Jul 31, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2025
@openshift-ci-robot
Copy link

@dfajmon: This pull request explicitly references no jira issue.

In response to this:

FeatureGates are different for OpenShift and upstream. This PR changes it so we have also FeatureGates from upstream enabled using endpoint /metrics from Prometheus.

This is a continuation of openshift/kubernetes#2317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ee7b5a8 and 2 for PR HEAD 1b61143 in total

@jsafrane
Copy link
Contributor

jsafrane commented Aug 1, 2025

/retest
quite some of the failed jobs failed to install a cluster

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 85efd76 and 1 for PR HEAD 1b61143 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8933dc6 and 0 for PR HEAD 1b61143 in total

@openshift-ci-robot
Copy link

/hold

Revision 1b61143 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2025
@jsafrane
Copy link
Contributor

jsafrane commented Aug 4, 2025

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b63b144 and 2 for PR HEAD 1b61143 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 47c179d and 1 for PR HEAD 1b61143 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025 •
edited
Loading

@dfajmon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 432890f link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/okd-e2e-gcp 432890f link false /test okd-e2e-gcp
ci/prow/e2e-aws-ovn-etcd-scaling e702f41 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-1of2 e702f41 link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-gcp-fips-serial-2of2 e702f41 link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-gcp-disruptive e702f41 link false /test e2e-gcp-disruptive
ci/prow/e2e-gcp-ovn-etcd-scaling e702f41 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 e702f41 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-azure-ovn-upgrade e702f41 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-vsphere-ovn-etcd-scaling e702f41 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling e702f41 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-openstack-serial e702f41 link false /test e2e-openstack-serial
ci/prow/e2e-aws-disruptive 1b61143 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-single-node-upgrade 1b61143 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn 1b61143 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 1b61143 link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-aws-proxy 1b61143 link false /test e2e-aws-proxy
ci/prow/e2e-metal-ipi-virtualmedia 1b61143 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 1b61143 link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-aws-ovn-cgroupsv2 1b61143 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-gcp-ovn-techpreview 1b61143 link false /test e2e-gcp-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 1b61143 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 1b61143 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-openstack-ovn 1b61143 link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack 1b61143 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/okd-scos-e2e-aws-ovn 1b61143 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link

openshift-trt bot commented Aug 5, 2025

Job Failure Risk Analysis for sha: 1b61143

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack IncompleteTests
Tests for this run (104) are below the historical average (2261): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-kube-apiserver-rollout IncompleteTests
Tests for this run (104) are below the historical average (1202): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-virtualmedia IncompleteTests
Tests for this run (104) are below the historical average (2213): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 47c179d and 2 for PR HEAD 1b61143 in total

@openshift-merge-bot openshift-merge-bot bot merged commit e9beb50 into openshift:main Aug 5, 2025
33 of 47 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202508051116.p0.ge9beb50.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stbenjam stbenjam stbenjam left review comments

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@sjenning sjenning Awaiting requested review from sjenning

+1 more reviewer

@jsafrane jsafrane jsafrane left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@stbenjam stbenjam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dfajmon @stbenjam @openshift-ci-robot @jsafrane @openshift-bot @openshift-merge-robot