Skip to content

Conversation

@everettraven
Copy link
Contributor

@everettraven everettraven commented Sep 8, 2025

When we introduced the tests for the ExternalOIDC* features we didn't realize that there was a standardized approach for using community-based images in our e2e tests and configured our tests to create a Keycloak deployment using a direct reference to the quay.io/keycloak/keycloak:25.0 image to exercise the behavior of configuring an external IdP.

This PR updates the allowed community images to include the quay.io/keycloak/keycloak:25.0 image and updates our Keycloak deployment helper to pull the correct location for the keycloak image.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the e2e-images-update Related to images used by e2e tests label Sep 8, 2025
@everettraven
Copy link
Contributor Author

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a3565a70-8cda-11f0-9abc-92987cd18695-0

@everettraven everettraven force-pushed the oidc/add-allowed-image branch from a389ddd to c72a2df Compare September 9, 2025 12:06
@everettraven everettraven changed the title wip: try adding keycloak to allowedImages CNTRLPLANE-945: images: add keycloak images and use them in ExternalOIDC tests Sep 9, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2025

@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven everettraven marked this pull request as ready for review September 9, 2025 12:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2025

@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

When we introduced the tests for the ExternalOIDC* features we didn't realize that there was a standardized approach for using community-based images in our e2e tests and configured our tests to create a Keycloak deployment using a direct reference to the quay.io/keycloak/keycloak:25.0 image to exercise the behavior of configuring an external IdP.

This PR updates the allowed community images to include the quay.io/keycloak/keycloak:25.0 image and updates our Keycloak deployment helper to pull the correct location for the keycloak image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven
Copy link
Contributor Author

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/026fe3f0-8d76-11f0-9ee3-28c4c87f7373-0

@everettraven
Copy link
Contributor Author

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5a0d0d90-8d8f-11f0-9e45-3f5441bbdf70-0

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image mirrored:

$ podman image exists quay.io/openshift/community-e2e-images:e2e-quay-io-keycloak-keycloak-25-0-rEIw9B2Zcc3L1M6k
$ echo $?
0

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
@everettraven
Copy link
Contributor Author

/retest

1 similar comment
@everettraven
Copy link
Contributor Author

/retest

@everettraven
Copy link
Contributor Author

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-vsphere-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-azure-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-gcp-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-dualstack-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-sno-external-oidc-configure-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

@everettraven: trigger 7 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-vsphere-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-azure-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-gcp-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-dualstack-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-sno-external-oidc-configure-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/404064b0-8e5d-11f0-82a5-7f0e929cfbbc-0

@everettraven
Copy link
Contributor Author

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-vsphere-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-azure-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-gcp-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-dualstack-external-oidc-configure-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-sno-external-oidc-configure-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

@everettraven: trigger 7 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-vsphere-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-azure-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-gcp-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-dualstack-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-sno-external-oidc-configure-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/521714c0-8e69-11f0-8f95-611d1f0cbd49-0

@everettraven
Copy link
Contributor Author

/verified by @everettraven

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 10, 2025
@openshift-ci-robot
Copy link

@everettraven: This PR has been marked as verified by @everettraven.

In response to this:

/verified by @everettraven

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 130265e and 2 for PR HEAD c72a2df in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 130265e and 2 for PR HEAD c72a2df in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 935e8a7 and 1 for PR HEAD c72a2df in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

@everettraven: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn c72a2df link false /test e2e-openstack-ovn
ci/prow/e2e-hypershift-conformance c72a2df link false /test e2e-hypershift-conformance
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway c72a2df link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-aws-ovn-single-node-serial c72a2df link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-virtualmedia c72a2df link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 c72a2df link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-aws-ovn-kube-apiserver-rollout c72a2df link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn c72a2df link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-single-node c72a2df link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-disruptive c72a2df link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven
Copy link
Contributor Author

/retest-required

@openshift-trt
Copy link

openshift-trt bot commented Sep 11, 2025

Job Failure Risk Analysis for sha: c72a2df

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive IncompleteTests
Tests for this run (106) are below the historical average (275): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-openstack-ovn IncompleteTests
Tests for this run (104) are below the historical average (2103): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-merge-bot openshift-merge-bot bot merged commit d4e21fc into openshift:main Sep 12, 2025
37 of 47 checks passed
@everettraven
Copy link
Contributor Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

@everettraven: new pull request created: #30250

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@everettraven everettraven changed the title CNTRLPLANE-945: images: add keycloak images and use them in ExternalOIDC tests OCPBUGS-61730,CNTRLPLANE-945: images: add keycloak images and use them in ExternalOIDC tests Sep 15, 2025
@openshift-ci-robot
Copy link

@everettraven: Jira Issue Verification Checks: Jira Issue OCPBUGS-61730
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-61730 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

When we introduced the tests for the ExternalOIDC* features we didn't realize that there was a standardized approach for using community-based images in our e2e tests and configured our tests to create a Keycloak deployment using a direct reference to the quay.io/keycloak/keycloak:25.0 image to exercise the behavior of configuring an external IdP.

This PR updates the allowed community images to include the quay.io/keycloak/keycloak:25.0 image and updates our Keycloak deployment helper to pull the correct location for the keycloak image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants