Skip to content

MULTIARCH-5391: Add Disruptive ImageStreamImportMode Tests into a Disruptive Suite #30239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 17, 2025
Merged

MULTIARCH-5391: Add Disruptive ImageStreamImportMode Tests into a Disruptive Suite #30239

merged 9 commits into from
Oct 17, 2025

Conversation

@jatinsu
Copy link
Contributor

@jatinsu jatinsu commented Sep 11, 2025

This PR is to move certain disruptive tests introduced in MULTIARCH-5318 into it's own disruptive suite

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2025
@openshift-ci openshift-ci bot requested review from bthurber and deads2k September 11, 2025 16:08
Prashanth684
Prashanth684 reviewed Sep 11, 2025
View reviewed changes
Prashanth684
Prashanth684 reviewed Sep 11, 2025
View reviewed changes
Prashanth684
Prashanth684 reviewed Sep 11, 2025
View reviewed changes
@openshift-trt
Copy link

openshift-trt bot commented Sep 12, 2025

Job Failure Risk Analysis for sha: d2012bf

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive IncompleteTests
Tests for this run (106) are below the historical average (203): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@jatinsu jatinsu changed the title WIP: Add Disruptive ImageStreamImportMode Tests into a Disruptive Suite Add Disruptive ImageStreamImportMode Tests into a Disruptive Suite Sep 17, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025
@Prashanth684
Copy link
Contributor

/cc @everettraven following up on the discussion about having the ImageStreamImportMode tests being disruptive - could you PTAL the changes?

everettraven
everettraven reviewed Sep 18, 2025
View reviewed changes
everettraven
everettraven reviewed Sep 18, 2025
View reviewed changes
@openshift-trt
Copy link

openshift-trt bot commented Sep 19, 2025

Job Failure Risk Analysis for sha: eddadef

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn Medium
[sig-network] Services should be rejected for evicted pods (no endpoints exist) [Suite:openshift/conformance/parallel] [Suite:k8s]
This test has passed 94.19% of 2530 runs on release 4.21 [Overall] in the last week.

@jatinsu jatinsu mentioned this pull request Sep 24, 2025
Merged
@jatinsu
Copy link
Contributor Author

jatinsu commented Sep 25, 2025

/test e2e-test-image-stream-import-mode

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2025
@jatinsu jatinsu force-pushed the ImageStreamImportMode branch from eddadef to 69f3386 Compare September 25, 2025 21:25
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2025
@jatinsu
Copy link
Contributor Author

jatinsu commented Sep 25, 2025

/test e2e-test-image-stream-import-mode

@openshift-trt
Copy link

openshift-trt bot commented Sep 26, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 69f3386

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift Medium - "install should succeed: MicroShift rebase" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-serial High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should report telemetry [Serial] [Late] [Suite:openshift/conformance/serial]" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.

New tests seen in this PR at sha: 69f3386

  • "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should report telemetry [Serial] [Late] [Suite:openshift/conformance/serial]" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "install should succeed: MicroShift rebase" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@jatinsu
Copy link
Contributor Author

jatinsu commented Sep 30, 2025

/test e2e-test-image-stream-import-mode-techpreview

@jatinsu
Copy link
Contributor Author

jatinsu commented Sep 30, 2025

/retest

@jatinsu
Copy link
Contributor Author

jatinsu commented Sep 30, 2025

/test e2e-test-image-stream-import-mode-techpreview

1 similar comment
@jatinsu
Copy link
Contributor Author

jatinsu commented Oct 1, 2025

/test e2e-test-image-stream-import-mode-techpreview

@openshift-trt
Copy link

openshift-trt bot commented Oct 1, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: eef51c6

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-test-image-stream-import-mode-techpreview Medium - "[sig-imageregistry][Suite:openshift/test-image-stream-import-mode-techpreview][OCPFeatureGate:ImageStreamImportMode][Serial][Disruptive] ImageStream API import mode should be Legacy if the import mode specified in image.config.openshift.io config is Legacy [apigroup:image.openshift.io]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-test-image-stream-import-mode-techpreview Medium - "[sig-imageregistry][Suite:openshift/test-image-stream-import-mode-techpreview][OCPFeatureGate:ImageStreamImportMode][Serial][Disruptive] ImageStream API import mode should be PreserveOriginal if the import mode specified in image.config.openshift.io config is PreserveOriginal [apigroup:image.openshift.io]" is a new test, and was only seen in one job.

New tests seen in this PR at sha: eef51c6

  • "[sig-imageregistry][Suite:openshift/test-image-stream-import-mode-techpreview][OCPFeatureGate:ImageStreamImportMode][Serial][Disruptive] ImageStream API import mode should be Legacy if the import mode specified in image.config.openshift.io config is Legacy [apigroup:image.openshift.io]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-imageregistry][Suite:openshift/test-image-stream-import-mode-techpreview][OCPFeatureGate:ImageStreamImportMode][Serial][Disruptive] ImageStream API import mode should be PreserveOriginal if the import mode specified in image.config.openshift.io config is PreserveOriginal [apigroup:image.openshift.io]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@Prashanth684 Prashanth684 requested a review from neisw October 3, 2025 18:21
@Prashanth684
Copy link
Contributor

/test e2e-test-image-stream-import-mode

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

@Prashanth684: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-csi

/test e2e-aws-jenkins

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-image-registry

/test e2e-aws-ovn-microshift

/test e2e-aws-ovn-microshift-serial

/test e2e-aws-ovn-serial-1of2

/test e2e-aws-ovn-serial-2of2

/test e2e-gcp-csi

/test e2e-gcp-ovn

/test e2e-gcp-ovn-builds

/test e2e-gcp-ovn-image-ecosystem

/test e2e-gcp-ovn-upgrade

/test e2e-metal-ipi-ovn-ipv6

/test e2e-vsphere-ovn

/test e2e-vsphere-ovn-upi

/test images

/test lint

/test okd-scos-images

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd

/test e2e-aws-disruptive

/test e2e-aws-etcd-certrotation

/test e2e-aws-etcd-recovery

/test e2e-aws-ovn

/test e2e-aws-ovn-cgroupsv2

/test e2e-aws-ovn-edge-zones

/test e2e-aws-ovn-etcd-scaling

/test e2e-aws-ovn-kube-apiserver-rollout

/test e2e-aws-ovn-kubevirt

/test e2e-aws-ovn-serial-fast

/test e2e-aws-ovn-serial-ipsec

/test e2e-aws-ovn-serial-publicnet-1of2

/test e2e-aws-ovn-serial-publicnet-2of2

/test e2e-aws-ovn-single-node

/test e2e-aws-ovn-single-node-serial

/test e2e-aws-ovn-single-node-techpreview

/test e2e-aws-ovn-single-node-techpreview-serial

/test e2e-aws-ovn-single-node-upgrade

/test e2e-aws-ovn-upgrade

/test e2e-aws-ovn-upgrade-rollback

/test e2e-aws-ovn-upi

/test e2e-aws-proxy

/test e2e-azure

/test e2e-azure-ovn-etcd-scaling

/test e2e-azure-ovn-upgrade

/test e2e-baremetalds-kubevirt

/test e2e-external-aws

/test e2e-external-aws-ccm

/test e2e-external-vsphere-ccm

/test e2e-gcp-disruptive

/test e2e-gcp-fips-serial-1of2

/test e2e-gcp-fips-serial-2of2

/test e2e-gcp-ovn-etcd-scaling

/test e2e-gcp-ovn-rt-upgrade

/test e2e-gcp-ovn-techpreview

/test e2e-gcp-ovn-techpreview-serial-1of2

/test e2e-gcp-ovn-techpreview-serial-2of2

/test e2e-gcp-ovn-usernamespace

/test e2e-hypershift-conformance

/test e2e-metal-ipi-ovn

/test e2e-metal-ipi-ovn-bgp-virt-dualstack

/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-dualstack-bgp

/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw

/test e2e-metal-ipi-ovn-dualstack-local-gateway

/test e2e-metal-ipi-ovn-kube-apiserver-rollout

/test e2e-metal-ipi-serial-1of2

/test e2e-metal-ipi-serial-2of2

/test e2e-metal-ipi-serial-ovn-ipv6-1of2

/test e2e-metal-ipi-serial-ovn-ipv6-2of2

/test e2e-metal-ipi-virtualmedia

/test e2e-metal-ovn-single-node-live-iso

/test e2e-metal-ovn-single-node-with-worker-live-iso

/test e2e-metal-ovn-two-node-arbiter

/test e2e-metal-ovn-two-node-fencing

/test e2e-openstack-ovn

/test e2e-openstack-serial

/test e2e-test-image-stream-import-mode-techpreview

/test e2e-vsphere-ovn-dualstack-primaryv6

/test e2e-vsphere-ovn-etcd-scaling

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-main-e2e-aws-csi

pull-ci-openshift-origin-main-e2e-aws-ovn-fips

pull-ci-openshift-origin-main-e2e-aws-ovn-image-registry

pull-ci-openshift-origin-main-e2e-aws-ovn-microshift

pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial

pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2

pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2

pull-ci-openshift-origin-main-e2e-aws-ovn-single-node

pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-serial

pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade

pull-ci-openshift-origin-main-e2e-gcp-csi

pull-ci-openshift-origin-main-e2e-gcp-ovn

pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade

pull-ci-openshift-origin-main-e2e-metal-ipi-ovn

pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6

pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-main-e2e-openstack-ovn

pull-ci-openshift-origin-main-e2e-vsphere-ovn

pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi

pull-ci-openshift-origin-main-images

pull-ci-openshift-origin-main-lint

pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn

pull-ci-openshift-origin-main-okd-scos-images

pull-ci-openshift-origin-main-unit

pull-ci-openshift-origin-main-verify

pull-ci-openshift-origin-main-verify-deps

In response to this:

/test e2e-test-image-stream-import-mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-trt
Copy link

openshift-trt bot commented Oct 3, 2025

Job Failure Risk Analysis for sha: 4c32221

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (25) are below the historical average (647): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (146) are below the historical average (956): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@jatinsu
Copy link
Contributor Author

jatinsu commented Oct 7, 2025

@everettraven @neisw Would you mind taking a look at this? I ran the presubmit job against these changes and it passed. The reason why it's not ran against the most recent commit is because I accidentally named the test suite in the release repo test-image-stream-import-mode-techpreview, so I had to alter the name of the test suite in this pr to run the presubmit job and then change it back 🫠

@jatinsu jatinsu force-pushed the ImageStreamImportMode branch from 4c32221 to 06adeb9 Compare October 8, 2025 21:46
@neisw
Copy link
Contributor

neisw commented Oct 13, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@Prashanth684
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jatinsu, neisw, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jatinsu
Copy link
Contributor Author

jatinsu commented Oct 14, 2025

/retest-required

@Prashanth684 Prashanth684 changed the title Add Disruptive ImageStreamImportMode Tests into a Disruptive Suite MULTIARCH-5391: Add Disruptive ImageStreamImportMode Tests into a Disruptive Suite Oct 14, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2025 •
edited by openshift-ci bot
Loading

@jatinsu: This pull request references MULTIARCH-5391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This PR is to move certain disruptive tests introduced in MULTIARCH-5318 into it's own disruptive suite

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Prashanth684
Copy link
Contributor

/verified by @jatinsu

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 14, 2025
@openshift-ci-robot
Copy link

@Prashanth684: This PR has been marked as verified by @jatinsu.

In response to this:

/verified by @jatinsu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3ee15fc and 2 for PR HEAD 36ab967 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3250567 and 1 for PR HEAD 36ab967 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025 •
edited
Loading

@jatinsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia eddadef link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-disruptive eddadef link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn eddadef link false /test e2e-aws-ovn
ci/prow/e2e-test-image-stream-import-mode 69f3386 link false /test e2e-test-image-stream-import-mode
ci/prow/e2e-aws-ovn-edge-zones eef51c6 link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-single-node-upgrade 4c32221 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 4c32221 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 70d9ad2 and 0 for PR HEAD 36ab967 in total

@openshift-ci-robot
Copy link

/hold

Revision 36ab967 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025
@Prashanth684
Copy link
Contributor

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

@Prashanth684: Overrode contexts on behalf of Prashanth684: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Prashanth684
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 43159a2 into openshift:main Oct 17, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prashanth684 Prashanth684 Prashanth684 left review comments

@bthurber bthurber Awaiting requested review from bthurber

@deads2k deads2k Awaiting requested review from deads2k

@neisw neisw Awaiting requested review from neisw

+1 more reviewer

@everettraven everettraven everettraven left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Prashanth684 Prashanth684

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jatinsu @Prashanth684 @everettraven @neisw @openshift-ci-robot @openshift-merge-robot