Skip to content

OTA-1626: Handle unknown operators #30402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

OTA-1626: Handle unknown operators #30402

merged 1 commit into from
Nov 18, 2025
+17 −11

Conversation

@hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Oct 20, 2025 •
edited
Loading

Following up [1], the function parseClusterOperatorNames
raises up an error if it gets unknown operators which is a
result of CVO's producing a malformed message. It leads to
a failure associated to component "Cluster Version Operator".

[1]. #30269 (comment)

/hold

need to rebase after #30269 gets in

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2025 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

/hold

need to rebase after #30269 gets in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@openshift-trt
Copy link

openshift-trt bot commented Oct 21, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: bb48594

  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker cleanup" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker collection" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker interval construction" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker preparation" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker setup" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker test evaluation" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker writing to storage" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][bz-Cluster Version Operator] cluster version should not report Failing=Unknown during a normal cluster upgrade" [Total: 9, Pass: 9, Fail: 0, Flake: 0]

@hongkailiu hongkailiu force-pushed the OTA-1626-followup branch 2 times, most recently from d76087c to 0476313 Compare October 23, 2025 13:21
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Following up [1], the function parseClusterOperatorNames
raises up an error if it gets unknown operators which is a
result of CVO's producing a malformed message. It leads to
a failure associated to component "Cluster Version Operator".

[1]. #30269 (comment)

/hold

need to rebase after #30269 gets in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member Author

hongkailiu commented Oct 23, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@openshift-trt
Copy link

openshift-trt bot commented Oct 23, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 3c13a83

  • "Import the release payload "nightly-arm64" from an external source" [Total: 2, Pass: 2, Fail: 0, Flake: 0]

@hongkailiu
Copy link
Member Author

hongkailiu commented Oct 23, 2025

/retest-required

@DavidHurta
Copy link
Contributor

DavidHurta commented Oct 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2025
@hongkailiu
Copy link
Member Author

hongkailiu commented Oct 24, 2025

/hold

An issue is reported https://redhat-internal.slack.com/archives/C01CQA76KMX/p1761317258048499?thread_ts=1760731536.268309&cid=C01CQA76KMX

Let us fix that first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2025
@hongkailiu
OTA-1626: Handle unknown operators
b6995e9 
Following up [1], the function `parseClusterOperatorNames`
raises up an error if it gets unknown operators which is a
result of CVO's producing a malformed message. It leads to
a failure associated to component "Cluster Version Operator".

[1]. openshift#30269 (comment)
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@hongkailiu
Copy link
Member Author

hongkailiu commented Nov 6, 2025

/retest-required

@hongkailiu
Copy link
Member Author

hongkailiu commented Nov 11, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2025
@hongkailiu
Copy link
Member Author

hongkailiu commented Nov 11, 2025

/verified by "CI upgrade jobs"

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025

@hongkailiu: This PR has been marked as verified by "CI upgrade jobs".

In response to this:

/verified by "CI upgrade jobs"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta
Copy link
Contributor

DavidHurta commented Nov 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@petr-muller
Copy link
Member

petr-muller commented Nov 12, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2025

/retest-required

Remaining retests: 0 against base HEAD 4024c71 and 2 for PR HEAD b6995e9 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025

/retest-required

Remaining retests: 0 against base HEAD 9579913 and 1 for PR HEAD b6995e9 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025

/retest-required

Remaining retests: 0 against base HEAD 205da96 and 0 for PR HEAD b6995e9 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025

/hold

Revision b6995e9 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@hongkailiu
Copy link
Member Author

hongkailiu commented Nov 13, 2025

/retest-required

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025

/retest-required

Remaining retests: 0 against base HEAD 205da96 and 2 for PR HEAD b6995e9 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025

/retest-required

Remaining retests: 0 against base HEAD 782ff8b and 1 for PR HEAD b6995e9 in total

@openshift-trt
Copy link

openshift-trt bot commented Nov 14, 2025

Job Failure Risk Analysis for sha: b6995e9

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips IncompleteTests
Tests for this run (26) are below the historical average (3447): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@hongkailiu
Copy link
Member Author

hongkailiu commented Nov 14, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 14, 2025

/retest-required

Remaining retests: 0 against base HEAD b7d2a64 and 0 for PR HEAD b6995e9 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2025 •
edited
Loading

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn bb48594 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 15, 2025

/hold

Revision b6995e9 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2025
@hongkailiu
Copy link
Member Author

hongkailiu commented Nov 18, 2025

/retest-required

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 194c220 into openshift:main Nov 18, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@PratikMahajan PratikMahajan Awaiting requested review from PratikMahajan

2 more reviewers

@petr-muller petr-muller petr-muller approved these changes

@DavidHurta DavidHurta DavidHurta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DavidHurta DavidHurta

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hongkailiu @openshift-ci-robot @DavidHurta @petr-muller @openshift-merge-robot