[release-4.19] OCPBUGS-63727: CNTRLPLANE-1767:fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift #30440
Conversation
…est on ARO and Baremetal Hypershift
…erType enum Replaced three boolean flags (isHypershift, isAROHCPCluster, isBareMetalHypershift) with a single HostedClusterType enum field for better code maintainability and extensibility. Also added a comment explaining why ARO HCP uses port 7443. Changes: - Introduced HostedClusterType enum with values: Standalone, AROHCP, BareMetal, Other - Replaced three boolean fields with single hostedClusterType field - Updated all conditional logic to use the enum pattern - Added comment for ARO HCP port 7443 usage - Improved semantic clarity by aligning with HyperShift terminology This refactoring makes it easier to add new hosted cluster types in the future and prevents contradictory states from occurring. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CNTRLPLANE-1485 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle [release-4.19] CNTRLPLANE-1767:fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references CNTRLPLANE-1767 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.20.z" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance |
|
@wangke19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/278b1cf0-b543-11f0-9a70-7d94a7493d4e-0 |
|
The realted monitor test has been passed in https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-30440-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance/1983742530155450368 |
|
/verified by CI tests |
openshift-ci-robot
added
the
verified
|
@wangke19: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot, wangke19 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@wangke19: This pull request references CNTRLPLANE-1767 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.20.z" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle [release-4.19] OCPBUGS-63727: CNTRLPLANE-1767:fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/invalid-bug
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-63727, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@wangke19: This pull request references Jira Issue OCPBUGS-63727, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
This is an automated cherry-pick of #30307
/assign wangke19