Skip to content

remove styles that set show/hide solution message in content #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

remove styles that set show/hide solution message in content #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c161a22
remove more styles that point to nowhere
kswanson33 May 28, 2024
ff8923b
remove styles that set show/hide solution message in content
kswanson33 May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions styles/books/generic/webview.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,7 @@
@include add_settings((
Exercise: (
_selectors: ('[data-type="exercise"]'),
'Solution1:::border-top-color': (_ref: 'colorMap:::NoteBorder'),
'Solution2:::border-top-color': (_ref: 'colorMap:::NoteBorder'),
'Solution:::border-top-color': (_ref: 'colorMap:::NoteBorder'),
'ProblemsExercisesProblemBefore1:::color': (_ref: 'colorMap:::NoteText'),
'ProblemsExercisesProblemBefore2:::color': (_ref: 'colorMap:::NoteText'),
'ProblemsExercisesSolutionBefore1:::color': (_ref: 'colorMap:::NoteText'),
Expand Down
23 changes: 2 additions & 21 deletions styles/designs/webview/parts/_exercise-components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ $Exercise__Question__Stem: (
);
///

$Exercise__Solution1: (
_name: "Solution1",
$Exercise__Solution: (
_name: "Solution",
_subselector: ' [data-type="solution"]',
_properties: (
padding: '0.5em 1em',
Expand All @@ -123,17 +123,6 @@ $Exercise__Solution1: (
),
);

$Exercise__Solution2: (
_name: "Solution2",
_subselector: ' .solution',
_properties: (
padding: '0.5em 1em',
border-top-width: 0.1rem,
border-top-color: enum('ValueSet:::REQUIRED'),
border-top-style: solid,
),
);

$Exercise__Solution__Toggle: (
_name: "SolutionToggle",
_subselector: (' > .ui-toggle'),
Expand All @@ -146,14 +135,6 @@ $Exercise__Solution__Toggle: (
),
);

$Exercise__Solution__Toggle__Before: (
_name: "SolutionToggleBefore",
_subselector: ('::before'),
_properties: (
content: '"[Show/Hide Solution]"',
),
);

$Exercise__Solution__Toggle__Marker: (
_name: "SolutionToggleMarker",
_subselector:(' > summary.ui-toggle::-webkit-details-marker'),
Expand Down
19 changes: 2 additions & 17 deletions styles/designs/webview/parts/_exercise-shapes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,10 @@
$Exercise__Problem__MCAnswer__Pre,
)
)),
map-merge($Exercise__Solution1, (
map-merge($Exercise__Solution, (
_components: (
$Button--InExerciseSolution,
map-merge($Exercise__Solution__Toggle, (
_components: (
$Exercise__Solution__Toggle__Before,
),
)),
$Exercise__Solution__Toggle__Marker,
),
)),
map-merge($Exercise__Solution2, (
_components: (
$Button--InExerciseSolution,
map-merge($Exercise__Solution__Toggle, (
_components: (
$Exercise__Solution__Toggle__Before,
),
)),
$Exercise__Solution__Toggle,
$Exercise__Solution__Toggle__Marker,
),
)),
Expand Down
37 changes: 0 additions & 37 deletions styles/output/webview-generic.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,47 +1014,10 @@ a:hover {
cursor: pointer;
}

[data-type=exercise] [data-type=solution] > .ui-toggle::before {
content: "[Show/Hide Solution]";
}

[data-type=exercise] [data-type=solution] > summary.ui-toggle::-webkit-details-marker {
display: none;
}

[data-type=exercise] .solution {
padding: 0.5em 1em;
border-top-width: 0.1rem;
border-top-color: #dcdcdc;
border-top-style: solid;
}

[data-type=exercise] .solution .btn-link {
color: #21366b;
font-weight: 400;
border-radius: 0;
background-color: transparent;
-webkit-box-shadow: none;
box-shadow: none;
border-color: transparent;
}

[data-type=exercise] .solution > .ui-toggle {
font-weight: bold;
text-align: center;
text-transform: capitalize;
list-style: none;
cursor: pointer;
}

[data-type=exercise] .solution > .ui-toggle::before {
content: "[Show/Hide Solution]";
}

[data-type=exercise] .solution > summary.ui-toggle::-webkit-details-marker {
display: none;
}

[data-type=exercise].has-problem-title .os-problem-container {
display: initial;
}
Expand Down