Skip to content

Core 921 alegbra 1 pdf #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Aug 25, 2025
Merged

Core 921 alegbra 1 pdf #575

merged 43 commits into from
Aug 25, 2025

Conversation

TylerZeroMaster
Copy link
Contributor

@TylerZeroMaster TylerZeroMaster commented Jun 26, 2025 •
edited
Loading

@TylerZeroMaster
Use iconCondensedLabel for notes
c8ecdc9
@TylerZeroMaster
Style section.numbered-exercises as EverydayExercises
9bfcd1a
@TylerZeroMaster
Style unit page titles the same as chapter page titles
0247488
@TylerZeroMaster
Add borderless table an unindented list styles to algebra-1
2a98b3f
@TylerZeroMaster
Visually hide solutions in algebra-1
7ccfd93
@TylerZeroMaster
Add baseline max-width for images in algebra-1
2da7316
@TylerZeroMaster
Add text-only title support for algebra-1
41f6851
@TylerZeroMaster
Style th in tbody within corn
e5b6783
@TylerZeroMaster
Update note styles
d89ec9c
@TylerZeroMaster
Add os-raise-noindent for data-type=injected-exercise
dc81eef
@TylerZeroMaster
Style practice question numbers in bold to match exercises
72573c8
@TylerZeroMaster
Remove unindented style
6624626 
This wasn't working as intended. The lists without this style are closer to the desired result.
@TylerZeroMaster
Make TextOnlyChapterTitle a little easier to reuse if needed
d85f4d0
@TylerZeroMaster
Possible fix for table problems
c3fd615
@TylerZeroMaster
Try to match exercise styles as best as possible
b21b9ee
@TylerZeroMaster
Changelog
d89dbd4
@TylerZeroMaster
Use static max-width for table images
b83f611
@TylerZeroMaster
Use flex display for notes instead of table-cell
215b81a
@TylerZeroMaster TylerZeroMaster force-pushed the core-921-alegbra-1-pdf branch from 9008278 to 215b81a Compare July 21, 2025 14:23
@TylerZeroMaster
Add fix for labeled graphs
acc201b
@TylerZeroMaster
Add extra margin to headings and notes
e0a13ef
@TylerZeroMaster
Fix image scaling in exercises
ba3a748 
- Make exercise images smaller
- Limit max-width to 95% so that the images never overlap the numbering
@TylerZeroMaster
Add banding to os-eoc
545cc24 
Currently only practice sections
@TylerZeroMaster
Add document class notes
22179cf 
New icon borrowed from cardboard with theme recolor
@TylerZeroMaster
Fix document note
47e3681 
Come to find this note does not have title. That is kind of weird. This should work, though.

Tip: the icon is added to the first child and that first child will align with the icon.
@TylerZeroMaster
Fix contemporary math style
d6bd5b0 
These width/height settings weren't doing anything until I made it possible to adjust them.

I don't know why they were there to begin with.
@TylerZeroMaster
Add generic example title style for algebra-1
71061fd
@TylerZeroMaster
Enable page banding for custom-eoc in algebra-1
3f7a00f
@TylerZeroMaster
Ensure problem paras are full width
ba146c1
@TylerZeroMaster
Custom question numbering
f0315f2
@TylerZeroMaster TylerZeroMaster marked this pull request as ready for review August 25, 2025 15:33
RoyEJohnson
RoyEJohnson reviewed Aug 25, 2025
View reviewed changes
RoyEJohnson
RoyEJohnson approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@RoyEJohnson RoyEJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what everything does, but it looks like a generally consistent approach.

@TylerZeroMaster
Copy link
Contributor Author

I don't know what everything does, but it looks like a generally consistent approach.

Thank you for reviewing this. Some of it is not as consistent as I would like. There were quite a few one-offs in algebra-1 that I was not sure would be used going forward. In those cases, I stuck with plain css instead of trying to create new reusable components/shapes.

You might have inferred this already, but most of these changes were adding the ability to override certain properties. You can only override a property if it is one of enum('ValueSet:::OPTIONAL') or enum('ValueSet:::REQUIRED'). In cases where the property value is like (enum('ValueSet:::OPTIONAL'), 10px) that is making it so that the default value is 10px but it can still be set manually if needed.

@TylerZeroMaster TylerZeroMaster merged commit 4d72a1e into main Aug 25, 2025
2 checks passed
@TylerZeroMaster TylerZeroMaster deleted the core-921-alegbra-1-pdf branch August 25, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyEJohnson RoyEJohnson RoyEJohnson approved these changes

@jomcarvajal jomcarvajal jomcarvajal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerZeroMaster @RoyEJohnson @jomcarvajal