Skip to content

adds flag to skip adding source info attributes #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adds flag to skip adding source info attributes #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dockerfiles/docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ LOCAL_ATTIC_DIR=${LOCAL_ATTIC_DIR:-}
JAVA_DEBUG=${JAVA_DEBUG:-}
JS_DEBUG=${JS_DEBUG:-}
NODE_OPTIONS=${NODE_OPTIONS:-}
SKIP_SOURCE_INFO=${SKIP_SOURCE_INFO:-}

if [[ $JS_DEBUG ]]; then
export NODE_DEBUG_PORT=9229 # LCOV_EXCL_LINE
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/steps/step-prebake.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ cp -r "$IO_INITIAL_RESOURCES/." "$IO_RESOURCES"
repo_root=$IO_FETCH_META

# TODO: Pass file name pattern to node command and avoid the loop below
if [[ $LOCAL_ATTIC_DIR != '' ]]; then
if [[ $LOCAL_ATTIC_DIR != '' && -z $SKIP_SOURCE_INFO ]]; then
echo 'Annotating XML files with source map information (data-sm="...")'
pushd $IO_FETCH_META > /dev/null
files=$(find . -name '*.cnxml' -or -name '*.collection.xml')
Expand Down
3 changes: 3 additions & 0 deletions enki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ show_help() {
--pdb Enable Python debugging
--jdb Enable Java debugging
--jsdb Enable Javascript debugging
--skip-source-info Skip adding source file/line/column to CNXML elements

Status:

Expand Down Expand Up @@ -170,6 +171,7 @@ while [ -n "$1" ]; do
--pdb) PYTHON_DEBUG=1 ;;
--jdb) JAVA_DEBUG=1 ;;
--jsdb) JS_DEBUG=1 ;;
--skip-source-info) export SKIP_SOURCE_INFO=1 ;;
*)
echo -e "Invalid argument '$1'"
show_help
Expand Down Expand Up @@ -296,6 +298,7 @@ docker run $ports $interactive $enable_tty \
--env START_AT_STEP \
--env STOP_AT_STEP \
--env LOCAL_SIDELOAD_REPO_PATH \
--env SKIP_SOURCE_INFO \
--env KCOV_DIR \
--env __CI_KCOV_MERGE_ALL__\
$envs \
Expand Down