Skip to content

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Sep 4, 2025

@RoyEJohnson RoyEJohnson force-pushed the core-1151-fix-cookie-yes-gtm-integration branch from fdb52f0 to 8d32910 Compare September 4, 2025 20:03
Copy link
Member

@TomWoodward TomWoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine, looking at the diff i'm wondering if pardot and facebook also need to be updated

@RoyEJohnson RoyEJohnson force-pushed the core-1151-fix-cookie-yes-gtm-integration branch from 8d32910 to 7e829c7 Compare September 8, 2025 14:33
@RoyEJohnson
Copy link
Contributor Author

this looks fine, looking at the diff i'm wondering if pardot and facebook also need to be updated

Is GTM configured to load them as well? If so, it sounds like we can take them out of here at let it do its thing.

@RoyEJohnson RoyEJohnson force-pushed the core-1151-fix-cookie-yes-gtm-integration branch from 7e829c7 to dca5d10 Compare September 9, 2025 14:37
@TomWoodward
Copy link
Member

We would need to establish if they are currently loaded or not, but for them to be correctly not loaded based on the users consent settings we'd need to move them to gtm

What do those vendor scripts do?

@RoyEJohnson RoyEJohnson force-pushed the core-1151-fix-cookie-yes-gtm-integration branch from 9b2055d to 8cdc978 Compare September 15, 2025 17:36
Copy link
Member

@TomWoodward TomWoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're good to remove the pardot one as well

@RoyEJohnson RoyEJohnson merged commit 3cdf8b9 into main Sep 16, 2025
1 check passed
@RoyEJohnson RoyEJohnson deleted the core-1151-fix-cookie-yes-gtm-integration branch September 16, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants