Port errata-form page JavaScript files to TypeScript (CORE-1205) #2774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
core-1205-errata-form-typescript
branch
2 times, most recently
from
168a199 to
ea4d520
Compare
- Added comprehensive type definitions for all components - Converted 10 JavaScript files to TypeScript (.js -> .tsx/.ts) - Added proper typing for React components, hooks, and event handlers - Used inline type definitions and avoided 'any' type per guidelines - Maintained existing functionality while improving type safety Files converted: - errata-form.js -> errata-form.tsx - errata-form-context.js -> errata-form-context.tsx - form/form.js -> form/form.tsx - form/ErrorSourceSelector.js -> form/ErrorSourceSelector.tsx - form/ErrorTypeSelector.js -> form/ErrorTypeSelector.tsx - form/InvalidMessage.js -> form/InvalidMessage.tsx - form/FileUploader.js -> form/FileUploader.tsx - form/ErrorLocationSelector/*.js -> form/ErrorLocationSelector/*.tsx 🤖 Generated with [Claude Code](https://claude.ai/code) Lint issues selectedBook can be null Co-Authored-By: Claude <[email protected]>
RoyEJohnson
force-pushed
the
core-1205-errata-form-typescript
branch
from
7aa5c6a to
29afc21
Compare
RoyEJohnson
reviewed
Sep 17, 2025
| return ( | ||
| <React.Fragment> | ||
| <div className="question">Additional location information, if applicable</div> | ||
| <label className="question" htmlFor="additional_location_information"> |
There was a problem hiding this comment.
Accessibility change: made this a label with a for connection to the input
RoyEJohnson
reviewed
Sep 17, 2025
There was a problem hiding this comment.
Easier to see the changes in the individual commits.
RoyEJohnson
reviewed
Sep 17, 2025
There was a problem hiding this comment.
Easier to see changes in the individual commits
RoyEJohnson
reviewed
Sep 17, 2025
| return ( | ||
| <React.Fragment> | ||
| <div className="question">Where in the book did you find the error?</div> | ||
| <label className="question" htmlFor="toc-selector">Where in the book did you find the error?</label> |
There was a problem hiding this comment.
Accessibility issue (that also makes testing easier)
RoyEJohnson
reviewed
Sep 17, 2025
There was a problem hiding this comment.
Again, easier to see the changes in the individual commits
RoyEJohnson
reviewed
Sep 17, 2025
| }} | ||
| onValueUpdate={setTitle} | ||
| label="What book were you in, again?" options={assertDefined(options)} /> | ||
| label="What book were you in, again?" options={options ?? []} /> |
There was a problem hiding this comment.
Turned out it's not always defined
jivey
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
There are three commits:
Summary
anytypetypetointerfaceFiles Converted
errata-form.js→errata-form.tsx- Main component with Book and SelectOption typeserrata-form-context.js→errata-form-context.tsx- Context with comprehensive ContextValue typeform/form.js→form/form.tsx- Form component with ApiResponse and semester typesform/ErrorSourceSelector.js→form/ErrorSourceSelector.tsx- Source selector with BookResource and BookInfo typesform/ErrorTypeSelector.js→form/ErrorTypeSelector.tsx- Type selector with proper event typingform/InvalidMessage.js→form/InvalidMessage.tsx- Invalid message utility with strict return typesform/FileUploader.js→form/FileUploader.tsx- File upload component with FileButtonPropsform/ErrorLocationSelector/ErrorLocationSelector.js→.tsx- Location selector with component prop typesform/ErrorLocationSelector/toc-selector.js→.tsx- TOC selector with TreeEntry and TocContent typesform/ErrorLocationSelector/test-data.js→.ts- Test data file (simple rename)Technical Details
All components maintain existing functionality while adding comprehensive type safety. TypeScript definitions include proper React component types, event handlers, hook return types, and API response structures.
Test Plan
Related to: https://openstax.atlassian.net/browse/CORE-1205
🤖 Generated with Claude Code