osweb qa tests to complete existing rex tests #2570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWoodward
temporarily deployed
to
rex-web-osweb-dqqhxelns64aaz2i
Dantemss
previously requested changes
Sep 16, 2025
|
|
||
| assert home.footer_section_bottom_is_visible | ||
|
|
||
| assert "Rice University" and "license" in await home.footer_section_bottom_is_visible.inner_text() |
There was a problem hiding this comment.
The in operator has higher precedence than and so this is equivalent to assert "Rice University" and ("license" in await home.footer_section_bottom_is_visible.inner_text()) so the "Rice University" part is not testing anything. So you either need 2 different asserts or use in twice, like: "Rice University" in ... and "license" in ...
| await home.click_learn_about_openstax_link() | ||
|
|
||
| assert f"{base_url}/about" == chrome_page.url | ||
| assert "Who we are" and "What we do" and "Where we're going" in await home.about_page.inner_text() |
TomWoodward
temporarily deployed
to
rex-web-osweb-dqqhxelns64aaz2i
|
@Dantemss The fails are due to a "Make a gift" overlay appearing on staging.openstax... When rerunning them and getting rid of the overlay, they pass. |
TomWoodward
temporarily deployed
to
rex-web-osweb-dqqhxelns64aaz2i
|
@Dantemss I think this still waits for your re-approval... |
TomWoodward
temporarily deployed
to
rex-web-osweb-dqqhxelns64aaz2i
TomWoodward
temporarily deployed
to
rex-web-osweb-dqqhxelns64aaz2i
Dantemss
requested changes
Sep 22, 2025
TomWoodward
temporarily deployed
to
rex-web-osweb-dqqhxelns64aaz2i
TomWoodward
temporarily deployed
to
rex-web-osweb-dqqhxelns64aaz2i
|
@Dantemss fixed the issues. Thanks for pointing them out |
TomWoodward
temporarily deployed
to
rex-web-osweb-dqqhxelns64aaz2i
Dantemss
approved these changes
Sep 24, 2025
| def philanthropic_support_section(self): | ||
| return self.page.locator("section.philanthropic-support") | ||
| @pytest.mark.asyncio | ||
| async def philanthropic_support_section(self): |
There was a problem hiding this comment.
This one maybe should end in _is_visible
| def footer_section(self): | ||
| return self.page.locator("id=footer") | ||
| @pytest.mark.asyncio | ||
| async def footer_section(self): |
TomWoodward
temporarily deployed
to
rex-web-osweb-dqqhxelns64aaz2i
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-988