Skip to content

Conversation

antlerminator
Copy link

@antlerminator antlerminator commented Aug 14, 2025

Description

clear_small_nomination_if_required now validates that alpha_stake > 0 before it proceeds to clear the small nomination. This fixes the issue where the function would emit unnecessary StakeRemoved and Deposit events with zero values.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@antlerminator antlerminator marked this pull request as ready for review August 14, 2025 13:00
@open-junius
Copy link
Contributor

need to rebase to fix the failed unit testcase.

@antlerminator antlerminator force-pushed the no-zero-small-nomination-clear branch from edfb17b to 0aa0cb0 Compare August 18, 2025 10:11
@antlerminator
Copy link
Author

@open-junius Did the rebase and ran the tests again locally. Everything seems to be working, not sure what's the issue with the CI

@open-junius
Copy link
Contributor

No worry. I just need to approve the CI process again. Let's see the result this time.

@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Aug 18, 2025
@antlerminator
Copy link
Author

@open-junius Any idea what might be the root issue here?

@open-junius
Copy link
Contributor

@open-junius Any idea what might be the root issue here?

It is my bad, changed a parameter before. cause some e2e test failed. should be fixed soon.

@open-junius open-junius merged commit 9ca9888 into opentensor:devnet-ready Aug 28, 2025
153 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants