Skip to content

Conversation

@open-junius
Copy link
Contributor

Description

The pr improves the doc for storage definition in subtensor pallet.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this Oct 20, 2025
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Oct 20, 2025
Comment on lines 366 to 368
pub fn DefaultDelegateTake<T: Config>() -> u16 {
T::InitialDefaultDelegateTake::get()
}
Copy link
Collaborator

@l0r1s l0r1s Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs a cleanup because this makes no sense to wrap the #[pallet::constant] into a type value, we can just use it like that, type_value derives a Get<T> implementation that is already existing for InitialDefaultDelegateTake

Also, a lot of these type values are not used anywhere

edit: I added this to the #2047 issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assigned the #2047 to me. Let's merge the PR at first, then we have correct doc for rust doc and type script. I will create a new PR for 2047.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants