-
Notifications
You must be signed in to change notification settings - Fork 244
Fix doc for storage #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devnet-ready
Are you sure you want to change the base?
Fix doc for storage #2144
Conversation
| pub fn DefaultDelegateTake<T: Config>() -> u16 { | ||
| T::InitialDefaultDelegateTake::get() | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs a cleanup because this makes no sense to wrap the #[pallet::constant] into a type value, we can just use it like that, type_value derives a Get<T> implementation that is already existing for InitialDefaultDelegateTake
Also, a lot of these type values are not used anywhere
edit: I added this to the #2047 issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assigned the #2047 to me. Let's merge the PR at first, then we have correct doc for rust doc and type script. I will create a new PR for 2047.
Description
The pr improves the doc for storage definition in subtensor pallet.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.