Skip to content

Conversation

@zzcr
Copy link
Member

@zzcr zzcr commented Nov 6, 2025

fix: 修复icon-saas依赖theme-saas包版本错误问题

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Chores
    • Updated internal build configuration to optimize package version handling mechanics.

@github-actions github-actions bot added the bug Something isn't working label Nov 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Walkthrough

The '@opentiny/vue-theme-saas' package is added to the isOnlyHasV3Packages list within the getBaseConfig function, expanding the internal set of packages classified for V3-specific versioning mechanics and dependency version replacement behavior.

Changes

Cohort / File(s) Summary
Version handling package list
internals/cli/src/commands/build/build-ui.ts
Added '@opentiny/vue-theme-saas' to isOnlyHasV3Packages array in getBaseConfig to classify the package as V3-only for version management and dependency replacement logic

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A package joins the V3 fold,
Where sass themes dance and UI turns gold,
One line added, versioning flows,
Through build commands the config grows! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding '@opentiny/vue-theme-saas' to the isOnlyHasV3Packages list to fix icon-saas's dependency on the wrong version of theme-saas.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch zzc/fix-icon-saas-dependence-1106

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d64cfc and 6ccd3d1.

📒 Files selected for processing (1)
  • internals/cli/src/commands/build/build-ui.ts (1 hunks)
🔇 Additional comments (1)
internals/cli/src/commands/build/build-ui.ts (1)

142-142: Good fix for the version dependency issue.

Adding @opentiny/vue-theme-saas to the V3-only packages list ensures that vue-icon-saas correctly depends on version 3.x regardless of the target Vue version, preventing Vue 2 builds from attempting to reference 2.x versions that don't exist. This is consistent with the existing @opentiny/vue-theme entry and directly addresses the issue.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants