Skip to content

Wrap Redis connection based on type of RedisConnection in RedisAspect #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wrap Redis connection based on type of RedisConnection in RedisAspect #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...ud-redis-starter/src/main/java/io/opentracing/contrib/spring/cloud/redis/RedisAspect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ public void getClusterConnection() {}

/**
* Intercepts calls to {@link RedisConnectionFactory#getConnection()} (and related), wrapping the
* outcome in a {@link TracingRedisConnection}
* outcome in a {@link TracingRedisConnection} or a {@link TracingRedisClusterConnection}
*
* @param pjp the intercepted join point
* @return a new {@link TracingRedisConnection} wrapping the result of the joint point
* @return a new {@link TracingRedisConnection} or {@link TracingRedisClusterConnection} wrapping the result of the joint point
*/
@Around("getConnection() && connectionFactory()")
public Object aroundGetConnection(final ProceedingJoinPoint pjp) throws Throwable {
Expand All @@ -70,6 +70,9 @@ public Object aroundGetConnection(final ProceedingJoinPoint pjp) throws Throwabl
.withSpanNameProvider(RedisSpanNameProvider.PREFIX_OPERATION_NAME(prefixOperationName))
.build();

if(connection instanceof RedisClusterConnection) {
return new TracingRedisClusterConnection((RedisClusterConnection) connection, tracingConfiguration);
}
return new TracingRedisConnection(connection, tracingConfiguration);
}

Expand Down