Skip to content

Conversation

mryzhov
Copy link
Contributor

@mryzhov mryzhov commented Aug 19, 2025

Details:

  • Added support of different split outputs in the transformation
  • improved unit tests

Tickets:

…t#31720)

### Details:
 - Added support of different split outputs in the transformation
 - improved unit tests
 
### Tickets:
 - *CVS-171208*
 - *CVS-171840*
@mryzhov mryzhov requested a review from a team as a code owner August 19, 2025 11:08
@mryzhov mryzhov requested review from itikhono and removed request for a team August 19, 2025 11:08
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Aug 19, 2025
@moslex moslex added this to the 2025.3 milestone Aug 20, 2025
@Wovchena Wovchena requested a review from Copilot August 20, 2025 11:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the RoPEFusionQwen transformation by adding support for different split outputs and improving unit tests. The transformation was previously hardcoded to handle specific split output indices, but now dynamically determines which QKV component (query or key) is being processed.

  • Replaced hardcoded split output ID parameter with dynamic detection of split output index
  • Refactored test to be parameterized and test both query (index 0) and key (index 1) components
  • Improved test readability by using cleaner variable names and better comments

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
fuse_rotary_positional_embeddings.hpp Removed split_output_id parameter from RoPEFusionQwen constructor
fuse_rotary_positional_embeddings.cpp Updated transformation to dynamically detect split output index and removed duplicate pass registrations
fuse_rotary_positional_embeddings.cpp (test) Converted test to parameterized format and improved readability with better variable names

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dorloff dorloff enabled auto-merge August 20, 2025 11:39
@dorloff dorloff added this pull request to the merge queue Aug 20, 2025
Merged via the queue into openvinotoolkit:releases/2025/3 with commit 2b18f70 Aug 20, 2025
208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: transformations OpenVINO Runtime library - Transformations Code Freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants