-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[GPU] check the feature padding at onednn reorder #31797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] check the feature padding at onednn reorder #31797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the OneDNN reorder implementation where feature axis padding was not being properly checked, causing unsupported operations to be attempted instead of falling back to OpenCL.
- Added feature axis padding validation to the
is_supported_pad()
function - Modified the return condition to include the new feature padding check alongside existing spatial and batch padding checks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR in the master branch has been approved.
bool no_feature_padding = true; | ||
no_feature_padding &= (pad._lower_size[1] == 0); | ||
no_feature_padding &= (pad._upper_size[1] == 0); | ||
|
||
return no_feature_padding; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool no_feature_padding = true; | |
no_feature_padding &= (pad._lower_size[1] == 0); | |
no_feature_padding &= (pad._upper_size[1] == 0); | |
return no_feature_padding; | |
return (pad._lower_size[1] == 0) && (pad._upper_size[1] == 0); |
Can be refactored?
3f8d8b7
to
0598987
Compare
build_jenkins |
0598987
to
41eb55d
Compare
41eb55d
to
80e9129
Compare
### Description of the issue(symptom, root-cause, how it was resolved) - onednn reorder can not handle the feature axis padding. 'is_supported_pad()' function does not check the feature axis padding. - fallback to ocl if the reorder has the feature axis padding. #### The code and line that caused this issue (if it is not changed directly) - src/plugins/intel_gpu/src/graph/impls/onednn/reorder_onednn.cpp - src/plugins/intel_gpu/src/graph/impls/onednn/utils.cpp #### Reproduction step and snapshot (if applicable. Do not attach for customer model) - reproducer is attached in the ticket <img width="912" height="446" alt="image" src="https://github.com/user-attachments/assets/db41a6f7-8738-4012-b5d7-6259cb922a0e" /> #### Problematic graph <img width="1308" height="885" alt="image" src="https://github.com/user-attachments/assets/b4ee632b-8375-4185-b7d1-b31bfe95b786" /> #### Checklist - [ ] Is it a proper fix? (not a workaround) - [ ] Did you include test case for this fix, if necessary? - [ ] Did you review existing test that can be extended to cover this scenario? Which test did you review? ### Tickets: - 172242
3b461d5
Description of the issue(symptom, root-cause, how it was resolved)
The code and line that caused this issue (if it is not changed directly)
Reproduction step and snapshot (if applicable. Do not attach for customer model)
Problematic graph
Checklist
Tickets: