Skip to content

Conversation

byungilm
Copy link
Contributor

@byungilm byungilm commented Aug 19, 2025

Description of the issue

  • symptom: audio output file is invalid. (Empty audio file) Output file of fp32 inference sounds fine.

  • root-cause: Matmul layer generated 'inf' value to output

image intermediate buffer comparison with fp32 inference :
Dst0 data1 shape: [1, 2, 1, 411, 411] data2 shape: [1, 2, 1, 411, 411] Number of items: 337842 / 337842 Max value: inf / 738612.875 Min value: -inf / -1369326.500 Max per-pixel diff: inf Total per-pixel diff: inf Average per-pixel diff: inf Total sign diff: 232
Src1 data1 shape: [1, 2, 1, 96, 411] data2 shape: [1, 2, 1, 96, 411] Number of items: 78912 / 78912 Max value: 529.000 / 527.687 Min value: -523.500 / -522.751 Max per-pixel diff: 3.043 Total per-pixel diff: 18146.697 Average per-pixel diff: 0.230 Total sign diff: 19
Src2 data1 shape: [1, 2, 1, 411, 411] data2 shape: [1, 2, 1, 411, 411] Number of items: 337842 / 337842 Max value: 295.500 / 296.001 Min value: -281.250 / -281.503 Max per-pixel diff: 0.920 Total per-pixel diff: 611.090 Average per-pixel diff: 0.002 Total sign diff: 1
Src0 data1 shape: [1, 2, 1, 411, 96] data2 shape: [1, 2, 1, 411, 96] Number of items: 78912 / 78912 Max value: 58.031 / 58.034 Min value: -58.031 / -57.976 Max per-pixel diff: 0.251 Total per-pixel diff: 1893.853 Average per-pixel diff: 0.024 Total sign diff: 44

ACTIVATIONS_SCALE_FACTOR did not work for this case.

  • how resolved:
    Add matching case of Select layer to a matcher of ClampFP16OutputSoftmaxMatcher to prevent 'inf' value propagated through softmax

The code and line that caused this issue

  • Accuracy issue : Missing logic to prevent 'inf' value passed to softmax

Reproduction step and snapshot

  • Execute openvino notebooks/openvoice2-and-melotts

Checklist

  • Is it a proper fix? (not a workaround)
  • Did you include test case for this fix, if necessary?
  • Did you review existing test that can be extended to cover this scenario? Which test did you review? : reviewed unittests with "ClampFp16OutputTest"

Tickets:

@byungilm byungilm requested review from a team as code owners August 19, 2025 15:39
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Aug 19, 2025
Copy link
Contributor

@isanghao isanghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isanghao isanghao enabled auto-merge August 20, 2025 07:10
@isanghao isanghao added this pull request to the merge queue Aug 20, 2025
Merged via the queue into openvinotoolkit:master with commit 0d51dfb Aug 20, 2025
190 of 191 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants