-
Couldn't load subscription status.
- Fork 71
feat: aot metered cost #2168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/aot
Are you sure you want to change the base?
feat: aot metered cost #2168
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
9b405e3 to
6e34a08
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2c7426e to
5d52991
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d45154e to
6a06185
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5235ff8 to
b125b27
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Thanks for re-organizing to share code.
- I didn't catch this before, but if each of
asm_bridge_*is actually a new crate, they should not go insidearch/or even inside thevm/folder. I'd suggest makingcrates/asmand then separate folders for each crate inside.
|
|
||
| // Helper to run AOT metered-cost and compare against interpreter baseline. | ||
| #[cfg(feature = "aot")] | ||
| macro_rules! run_aot_metered_cost_and_compare { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did this need to be a macro and not just a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and generally helped reorganize things structurally, but please address the comment that we shouldn't have crates inside vm/src/arch. These crates should be outside, e.g. crates/asm
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: 7d84792 |
Description
Adds support for AOT Metered Cost Execution
Testing
Modified existing
fn check_aot_equivalencefunction instark_utils.rsto assert consistency between AOT and Interpreted metered cost executionAdded additional tests in
extensions/native/circuit/tests/integration_test.rsto test various scenarios surroundingmetered_costCloses INT-5255