OpenCL AES: Correction for supporting two or more AES contexts at once #5826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently applies to AES-XTS, used by diskcryptor and truecrypt. Also separate Truecrypt kernel from the (potentially) shared PBKDF2-RIPE- MD160 code for good measure. Nvidia 550.144.03 bugs out on this for truecrypt so we revert that format to bitsliced AES (it doesn't matter for speed).
|
This was originally #5818. After that one was merged I paniced after seeing regressions and crashes so I reverted it in #5820 but I later realised that there was nothing wrong with it - I was juggling with too many branches and got confused. Anyway this code here (even sligthly improved since #5818) is what I've been running with for my tests since - it works fine and is even tested with debug output for verifying that work sizes end up correct vs. memory constraints. |
|
Tested a lot, works fine, ready for merge. |
solardiz
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently applies to AES-XTS, used by diskcryptor and truecrypt.
Also separate Truecrypt kernel from the (potentially) shared PBKDF2-RIPE- MD160 code for good measure.
Nvidia 550.144.03 bugs out on this for truecrypt so we revert that format to bitsliced AES (it doesn't matter for speed).