Skip to content

Bump webidl2 from 24.4.1 to 24.5.0 #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

Bump webidl2 from 24.4.1 to 24.5.0 #2590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76d8a19
Bump webidl2 from 24.4.1 to 24.5.0
dependabot[bot] Jul 24, 2025
80bab92
Ignore failing WebIDL validation rules
queengooborg Jul 29, 2025
d20fa59
Update test builder to handle new async_iterable type
queengooborg Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
"sinon": "21.0.0",
"typescript": "5.8.3",
"typescript-eslint": "^8.38.0",
"webidl2": "24.4.1",
"webidl2": "24.5.0",
"yaml": "2.8.0"
}
}
4 changes: 2 additions & 2 deletions test-builder/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ describe("build (API)", () => {
const ast = WebIDL2.parse(
`[Exposed=Window]
interface ReadableStream {
async iterable<any>;
async_iterable<any>;
};`,
);
assert.deepEqual(await buildIDLTests(ast, [], scopes), {
Expand All @@ -683,7 +683,7 @@ describe("build (API)", () => {
const ast = WebIDL2.parse(
`[Exposed=Window]
interface AsyncMap {
async iterable<DOMString, any>;
async_iterable<DOMString, any>;
};`,
);
assert.deepEqual(await buildIDLTests(ast, [], scopes), {
Expand Down
14 changes: 9 additions & 5 deletions test-builder/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,8 @@ const flattenMembers = (iface) => {
members.push({name: iface.name, type: "constructor"});
break;
case "iterable":
if (member.async) {
case "async_iterable":
if (member.async || member.type === "async_iterable") {
// https://webidl.spec.whatwg.org/#idl-async-iterable
members.push(
{name: "@@asyncIterator", type: "symbol"},
Expand Down Expand Up @@ -404,10 +405,13 @@ const getExposureSet = (node, scopes): Set<Exposure> => {
const validateIDL = (ast) => {
const validations = WebIDL2.validate(ast).filter((v) => {
// Ignore the [LegacyNoInterfaceObject] rule.
// XXX Also temporarily ignore the "[AllowShared] BufferSource -> AllowSharedBufferSource" rule until specs are fixed.
return !["no-nointerfaceobject", "migrate-allowshared"].includes(
v.ruleName,
);
// Also ignore the "async iterable -> async_iterable" rule until specs are fixed.
// Also ignore the rule that dictionary arguments without required fields must be marked optional (until the RTC spec is fixed)
return ![
"no-nointerfaceobject",
"obsolete-async-iterable-syntax",
"dict-arg-optional",
].includes(v.ruleName);
});
if (validations.length) {
const message = validations
Expand Down
Loading