Upgrade to @webref/css v7 #2751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ing or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
These are all defined in the spec for counter styles, but not in a way Webref can parse.
|
Attached is the changelog from this update. @Elchi3, would you be down to take a look and tell me if you think this list of added (and just as importantly, removed) tests is alright, or do we want to try and fine-tune it more before including it in the next collector release? |
|
Thanks @queengooborg, can you present this at the next BCD call? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CSS test generator to handle the new data structure of @webref/css v7.
A part of this upgrade involves flattening CSS types to get the enumerated values. In v6, Webref provided a
valuesproperty which sometimes had these values already flattened out, but not always. v7 removed thevaluesproperty, which now means that types had to be flattened. This creates a ton more tests as a result.