Add uncommon ecdsa oids and handle Crypt::PK::ECC omissions #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OIDS for ecdsa-with-sha1, recommended, and sha2 are missing but seen in the wild. Might as well include in the default table. (It's always been possible to register them) Check for the case of Crypt::PK::EC->new dieing in subjectPublicKeyParams, which can happen if the module loads, but doesn't understand the key. Treat it the same way as if the module isn't present - return undef in the keytype for the caller to handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OIDS for
ecdsa-with-sha1,-recommended, and-sha2are missing but seen in the wild. Might as well include in the default table. (It's always been possible to register them.)Check for the case of Crypt::PK::EC->new dieing in subjectPublicKeyParams, which can happen if the module loads, but doesn't understand the key. Treat it the same way as if the module isn't present - return undef in the keytype for the caller to handle.
See The OID repository for the OID references.
I've also entered an issue for Crypt::PKI::ECC for a couple of missing curves that were involved in this change to PKCS10. (Keeping up with crypto is a full-time job - but not mine.)
It's better to handle this more gracefully.