zpool/zfs: Add '-a|--all' option to scrub, trim, initialize. #17524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmilk
suggested changes
Jul 9, 2025
akashb-22
force-pushed
the
initialize_trim_a
branch
2 times, most recently
from
9dd8ee1 to
0d23aff
Compare
mcmilk
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
This looks good for me.
@behlendorf @tonyhutter - what do you think?
amotin
reviewed
Jul 14, 2025
akashb-22
force-pushed
the
initialize_trim_a
branch
3 times, most recently
from
23fb2b4 to
9465189
Compare
behlendorf
approved these changes
Jul 25, 2025
akashb-22
force-pushed
the
initialize_trim_a
branch
3 times, most recently
from
29ebe3a to
4472ba0
Compare
amotin
reviewed
Jul 28, 2025
tests/zfs-tests/tests/functional/cli_root/zpool_initialize/zpool_initialize_multiple_pools.ksh
Outdated
Show resolved
Hide resolved
Add support for the '-a | --all' option to perform trim, scrub, and initialize operations on all pools. Previously, specifying a pool name was mandatory for these operations. With this enhancement, users can now execute these operations across all pools at once, without needing to manually iterate over each pool from the command line. Signed-off-by: Akash B <[email protected]>
akashb-22
force-pushed
the
initialize_trim_a
branch
from
4472ba0 to
79fd0b5
Compare
amotin
approved these changes
Jul 29, 2025
behlendorf
added
Status: Accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the '-a | --all' option to perform trim, scrub, and initialize operations on all pools.
Previously, specifying a pool name was mandatory for these operations. With this enhancement, users can now execute these operations across all pools at once, without needing to manually iterate over each pool from the command line.
Motivation and Context
It would be helpful to have the ability to initiate these operations (scrub, trim, initialize) on multiple pools simultaneously.
Description
Add support for commands like zpool scrub -a, zpool trim -a, and zpool initialize -a to run the respective operation on all pools present in the system. This enhancement allows users to perform these tasks across all pools with a single command, improving efficiency and convenience.
How Has This Been Tested?
Tested this manually.
Types of changes
Checklist:
Signed-off-by.