Skip to content

🌱 Refactor applier to use HelmChartLoader #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

perdasilva
Copy link
Contributor

Description

Refactor how helm applier gets chart by adding an extra layer of abstraction to deal with multiple bundle/fs formats (i.e. helm and registry+v1) and move feature check to main.go

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2025
Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d14da9c
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6870d1b0a1926e0008b1e1f6
😎 Deploy Preview https://deploy-preview-2089--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

openshift-ci bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Per Goncalves da Silva <[email protected]>
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 73.97260% with 19 lines in your changes missing coverage. Please review.

Project coverage is 73.38%. Comparing base (134f887) to head (d14da9c).

Files with missing lines Patch % Lines
internal/operator-controller/applier/loader.go 34.48% 16 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
- Coverage   73.52%   73.38%   -0.15%     
==========================================
  Files          78       79       +1     
  Lines        7241     7281      +40     
==========================================
+ Hits         5324     5343      +19     
- Misses       1566     1582      +16     
- Partials      351      356       +5     
Flag Coverage Δ
e2e 44.06% <46.57%> (+0.15%) ⬆️
experimental-e2e 50.19% <50.68%> (-0.05%) ⬇️
unit 58.42% <38.35%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant