-
Notifications
You must be signed in to change notification settings - Fork 46
Add how-to change plotting backends guide #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
🚀 New features to boost your workflow:
|
Resolved after re-running the test. |
Codecov is failing because plotting is not being tested in an interactive environment. I could try and add a simple smoke test for test coverage. Thoughts? @timmens |
No, if the PR is ready, I'll try to merge it without the checks passing. Makes no sense in this case. Thank you! Is it ready for review? @r3kste |
Yes. It is ready for review @timmens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I have two relatively small remarks. Once these are done, this is ready to be merged! Thanks a lot.
This PR adds documentation on using different plotting backends.
Note: This PR should go after #641, as this relies on some fixes made to
criterion_plot()
Summary of Changes
Created
how_to_change_plotting_backend.ipynb
with information on:criterion_plot()
for each backend.Updated
how_to_visualize_histories.ipynb
with a small section on changing backends.To-do
matplotlib
not rendering the figure upon re-running cell.