[pull] main from llvm:main #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directives should not change the indentation level. Previously the program erroneously added an indentation level when it saw the `function` keyword.
The tool was crashing on Windows with ROCm 7.1 due to two issues: misuse of hipDeviceGet which should not be used (it worked before by accident but was undefined behavior), and ABI incompatibility from hipDeviceProp_t struct layout changes between HIP versions where the gcnArchName offset changed from 396 to 1160 bytes. The fix removes hipDeviceGet and queries properties directly by device index. It defines separate struct layouts for R0600 (HIP 6.x+) and R0000 (legacy) to handle the different memory layouts correctly. An automatic API fallback mechanism tries R0600, then R0000, then the unversioned API until one succeeds, ensuring compatibility across different HIP runtime versions. A new --hip-api-version option allows manually selecting the API version when needed. Additional improvements include enhanced error handling with hipGetErrorString, verbose logging throughout the detection process, and runtime version detection using hipRuntimeGetVersion when available. The versioned API functions provide stable ABI across HIP versions. Fixes: SWDEV-564272
…ttempt 2) (#167800) This re-lands #166005, which was reverted due to the issue described in #167797. There are 4 small changes: - Fix LoadedModule leak by calling Clear() on the modules list - Fix internal_strncpy calls that are not null-terminated - Improve test to accept the dylib being loaded from a different path than compiled `{{.*}}[[DYLIB]]` - strcmp => internal_strncmp This should not be merged until after #167797. rdar://163149325
…67983) Pointed out in code review downstream: swiftlang#11816
Fix Endianess issue with getting shadow 4 bytes corresponding to the first origin pointer. --------- Co-authored-by: anoopkg6 <[email protected]>
… where possible (#167041) The current implementation of the WMMA intrinsic ops as they are defined in the ROCDL tablegen is incorrect. They represent as operands what should be attributes such as `clamp`, `opsel`, `signA/signB`. This change performs a refactoring to bring it in line with what we expect. --------- Signed-off-by: Muzammiluddin Syed <[email protected]>
This adds the necessary handler for emitting an l-value for an ExprWithCleanups expression.
This is unused.
Prior to this patch, libcalls inserted by the `SelectionDAG` legalizer could never be tailcalled. The eligibility of libcalls for tail calling is is partly determined by checking `TargetLowering::isInTailCallPosition` and comparing the return type of the libcall and the caller. `isInTailCallPosition` in turn calls `TargetLowering::isUsedByReturnOnly` (which always returns false if not implemented by the target).
…165264) jobserver tests deterministic - Replace call-once wrapper in Parallel.cpp with a function-local static default executor. - Rework Jobserver tests for parallelFor/parallelSort to run in a fresh subprocess. The parent test spawns the current test binary with a gtest filter selecting a child test, ensuring the child process initializes the default executor after setting parallel::strategy = jobserver_concurrency() and after setting up a FIFO-backed jobserver proxy. This makes the tests reliable and independent from prior executor initialization in the combined SupportTests binary.
…sspecified (#155160) Implemented in LLVM15: e53c461 This LWG concerns`lazy_split_view` despite the outdated title. Closes #104320 # References - https://wg21.link/LWG3505 - https://wg21.link/range.lazy.split.outer Co-authored-by: Hristo Hristov <[email protected]>
Use the generalized handleVectorPmaddIntrinsic(), but multiplication by an initialized zero does not guarantee that the result is zero (counter-example: multiply zero by NaN).
#167954) This will allow fixing up the handling of AVX2 phadd/phsub instructions in a future patch, by setting Shards = 2. Currently, the extra functionality is not used.
This is almost always useful information and ::print() is debug-only code.
…167950) As it appears, all our files already follow it. Adding this for future PR with new checks
…d make (#165264)" This reverts commit b196c52. This broke premerge both within the PR and afterwards: 1. https://github.com/llvm/llvm-project/actions/runs/19351188603 2. https://lab.llvm.org/staging/#/builders/21/builds/8845 Other buildbots were failing as well: 1. https://lab.llvm.org/buildbot/#/builders/46/builds/26346
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )