[FSSDK-12030] Update: Exclude CMAB from UserProfileService #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new DecisionResponse(variation, reasons); | ||
| } | ||
| } | ||
| boolean ignoreUPS = false; |
Contributor
There was a problem hiding this comment.
Looks like we enforce to false, shouldn't we set the decideOptions value.
Contributor
Author
There was a problem hiding this comment.
Currently the decideOptions value is binded with UserProfileTracker. If decideOptions disables UPS, tracker is null. This ignoreUPS variable is only for cmab in this context. We can initialize it using the decideOptions field too. Should work fine.
Contributor
There was a problem hiding this comment.
In that case leave a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CMAB experiments are excluded from user profile service to allow dynamic decision-making
Test plan
All existing tests should pass. Added new unit tests.
Issues
FSSDK-12030