Skip to content

[GR-67262] Fix JFR GC events. #11570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ public void emitGarbageCollectionEvent(UnsignedWord gcEpoch, GCCause cause, long
JfrNativeEventWriter.beginSmallEvent(data, JfrEvent.GarbageCollection);
JfrNativeEventWriter.putLong(data, startTicks);
JfrNativeEventWriter.putLong(data, duration);
JfrNativeEventWriter.putEventThread(data);
JfrNativeEventWriter.putLong(data, gcEpoch.rawValue());
JfrNativeEventWriter.putLong(data, gcName.getId());
JfrNativeEventWriter.putLong(data, cause.getId());
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
/*
* Copyright (c) 2022, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2022, 2022, Red Hat Inc. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the copyright years of this file to 2025 if this is fine with you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please! I forgot to update that. Thanks

* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation. Oracle designates this
* particular file as subject to the "Classpath" exception as provided
* by Oracle in the LICENSE file that accompanied this code.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

package com.oracle.svm.test.jfr;

import com.oracle.svm.core.jfr.JfrEvent;
import jdk.jfr.Recording;
import jdk.jfr.consumer.RecordedEvent;
import org.junit.Test;

import java.util.HashSet;
import java.util.List;
import java.util.Set;

import static org.junit.Assert.assertTrue;

public class TestGarbageCollectionEvents extends JfrRecordingTest {
@Test
public void test() throws Throwable {
String[] events = new String[]{JfrEvent.GarbageCollection.getName()};
Recording recording = startRecording(events);
System.gc();
System.gc();
System.gc();
stopRecording(recording, TestGarbageCollectionEvents::validateEvents);
}

private static void validateEvents(List<RecordedEvent> events) {
assertTrue(events.size() > 0);
int foundSystemGc = 0;
Set<Integer> ids = new HashSet<>();
for (RecordedEvent event : events) {
assertTrue(!ids.contains(event.getInt("gcId")));
ids.add(event.getInt("gcId"));
assertTrue(event.getThread("eventThread").getJavaName() != null);
assertTrue(!event.getDuration().isZero());
assertTrue(event.getString("name") != null);
assertTrue(event.getLong("longestPause") > 0);
assertTrue(event.getLong("sumOfPauses") > 0);
if (event.getString("cause").equals("java.lang.System.gc()")) {
foundSystemGc++;
}
}
assertTrue(foundSystemGc >= 3);
}
}
Loading